linux-kernel - Re: Are we still willing to pay the cost of moving include/linux/irqdesc.h into kernel/irq/?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1505181635480.4225@nanos>
Date:	Mon, 18 May 2015 16:46:42 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Jiang Liu <jiang.liu@...ux.intel.com>
cc:	linux-kernel@...r.kernel.org
Subject: Re: Are we still willing to pay the cost of moving include/linux/irqdesc.h
 into kernel/irq/?

Jiang,

On Mon, 18 May 2015, Jiang Liu wrote:

> Hi Thomas,
> 	When refining irq related data structures, I found once we had
> a plan to move include/linux/irqdesc.h into kernel/irq/, and I have

I had that plan for two reasons:

  1) Is was tired of chasing the abuse of irq_desc

  2) We wanted to move irq descriptor memory allocation when
     affinity changes to a different node.

> basic ideas about how to achieve the goal as:
> 1) de-inline accessor functions in irqdesc.h and move the declaration
>    into linux/irq.h.
> 2) remove reference to irq_desc->xxxx from drivers one by one (this
>    step is simple)

Not sure. drivers/irqchip pretty much needs it and we have other
demeltiplex handlers which need it as well.

> 3) remove reference to irq_desc->xxxx from arch (this step is hard)

Same issue as #2

> 4) move irqdesc.h into kernel/irq/
> 
> But are we still willing to pay the cost of converting inline access
> helpers into normal functions?

I dont think so.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/