linux-kernel - Re: [PATCH v2] Staging: rtl8192u: Fix coding style issues at ieee80211_crypt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150518161531.GI22558@mwanda>
Date:	Mon, 18 May 2015 19:15:31 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Pedro Marzo Perez <marzo.pedro@...il.com>
Cc:	gregkh@...uxfoundation.org, navyasri.tech@...il.com,
	dilekuzulmez@...il.com, joe@...ches.com, haticeerturk27@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Staging: rtl8192u: Fix coding style issues at
 ieee80211_crypt_wep.c

On Mon, May 18, 2015 at 07:36:23PM +0200, Pedro Marzo Perez wrote:
> Merge two pr_debug lines with literal strings splitted across several lines
> into one single line, simplifying prism2_wep_init error check code.
> Openning braces should never be in a new line, move them to the end of
> the previous line.
> Removed two useless lines at ieee80211_wep_null.
> 

When Joe said "Some will say this is doing too many things in a single
patch." he meant Greg.  Break this up into multiple patches.  Especially
now that you've added even more stuff to it.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/