[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150518172259.GA8116@lst.de>
Date: Mon, 18 May 2015 19:22:59 +0200
From: Christoph Hellwig <hch@....de>
To: Jeff Moyer <jmoyer@...hat.com>
Cc: Ming Lin <mlin@...nel.org>, linux-kernel@...r.kernel.org,
Christoph Hellwig <hch@....de>, Jens Axboe <axboe@...nel.dk>,
Kent Overstreet <kent.overstreet@...il.com>,
Dongsu Park <dpark@...teo.net>,
Christoph Hellwig <hch@...radead.org>,
Al Viro <viro@...iv.linux.org.uk>,
Ming Lei <ming.lei@...onical.com>, Neil Brown <neilb@...e.de>,
Alasdair Kergon <agk@...hat.com>,
Mike Snitzer <snitzer@...hat.com>, dm-devel@...hat.com,
Lars Ellenberg <drbd-dev@...ts.linbit.com>,
drbd-user@...ts.linbit.com, Jiri Kosina <jkosina@...e.cz>,
Geoff Levand <geoff@...radead.org>, Jim Paris <jim@...n.com>,
Joshua Morris <josh.h.morris@...ibm.com>,
Philip Kelleher <pjk1939@...ux.vnet.ibm.com>,
Minchan Kim <minchan@...nel.org>,
Nitin Gupta <ngupta@...are.org>,
Oleg Drokin <oleg.drokin@...el.com>,
Andreas Dilger <andreas.dilger@...el.com>
Subject: Re: [PATCH v3 01/11] block: make generic_make_request handle
arbitrarily sized bios
On Mon, May 18, 2015 at 12:52:03PM -0400, Jeff Moyer wrote:
> > + return bio_split(bio, split_sectors, GFP_NOIO, bs);
>
> Much of this function is cut-n-paste from blk-lib.c. Is there any way
> to factor it out?
The code in blk-lib.c can go away now that any driver that cares
does the split.
> > +static struct bio *blk_bio_segment_split(struct request_queue *q,
> > + struct bio *bio,
> > + struct bio_set *bs)
> > +{
>
> Funny name for a function that also merges segments. ;-) I admit I am
> at a loss for coming up with a better name that won't overflow 80
> columns.
I'd keep the name and add a funny comment instead.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists