linux-kernel - [PATCH v2] Staging: comedi: fix line longer than 80 chars in cb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150518175600.sCK5zSm4c6w=%amaury.denoyelle@gmail>
Date:	Mon, 18 May 2015 19:56:00 +0200
From:	Amaury Denoyelle <amaury.denoyelle@...il.com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Ian Abbott <abbotti@....co.uk>, devel@...verdev.osuosl.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	H Hartley Sweeten <hsweeten@...ionengravers.com>,
	linux-kernel@...r.kernel.org
Subject: [PATCH v2] Staging: comedi: fix line longer than
 80 chars in cb_pcidas64.c

Sudip Mukherjee <sudipm.mukherjee@...il.com> wrote:

> On Sun, May 17, 2015 at 04:47:23PM +0200, Amaury Denoyelle wrote:
> > This patch fixes coding style errors reported by checkpatch.pl for
> > cb_pcidas64.c, about too long source code lines.
> > 
> > Signed-off-by: Amaury Denoyelle <amaury.denoyelle@...il.com>
> > ---
> <snip>
> >  }
> >  
> > -/* adjusts the size of hardware fifo (which determines block size for dma xfers) */
> > +/* adjusts the size of hardware fifo
> > + * (which determines block size for dma xfers) */
> 
> This is not the style for multi-line comments. Please check CodingStyle
> in Documentation.
> 
> >  static int set_ai_fifo_size(struct comedi_device *dev, unsigned int num_samples)
> >  {
> <snip>	
> >  
> > @@ -1987,8 +1990,8 @@ static unsigned int get_divisor(unsigned int ns, unsigned int flags)
> >  
> >  /* utility function that rounds desired timing to an achievable time, and
> >   * sets cmd members appropriately.
> > - * adc paces conversions from master clock by dividing by (x + 3) where x is 24 bit number
> > - */
> > + * adc paces conversions from master clock by dividing by (x + 3) where x is
> > + * 24 bit number */
> same here
> 
> and when you are sending just one patch, you do not need to mention
> [Patch 1/1] in the subject. just mention [Patch]
> 
> regards
> sudip

Thanks for your review. I was aware of the coding style for multi-line comments, but I chose to follow the same convention already used in the source file.

I submit a new version where I respect the coding style in the comments I fixed. I editted only multi-line comments that were too long, in order to not have a messy patch. If you think it's better to be done, maybe I could submit a two-part patch.

regards,

-- 
Amaury Denoyelle

Content of type "text/x-diff" skipped