linux-kernel - Re: [PATCH 1/1 linux-next] omap_vout: use swap() in omapvid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1601184049.17932.1431973900041.open-xchange@webmail.nmp.proximus.be>
Date:	Mon, 18 May 2015 20:31:40 +0200 (CEST)
From:	Fabian Frederick <fabf@...net.be>
To:	linux-kernel@...r.kernel.org,
	Vaibhav Hiremath <vaibhav.hiremath@...aro.org>
Cc:	linux-media@...r.kernel.org,
	Mauro Carvalho Chehab <mchehab@....samsung.com>
Subject: Re: [PATCH 1/1 linux-next] omap_vout: use swap() in omapvid_init()



> On 18 May 2015 at 20:20 Vaibhav Hiremath <vaibhav.hiremath@...aro.org> wrote:
>
>
>
>
> On Monday 18 May 2015 11:24 PM, Fabian Frederick wrote:
> > Use kernel.h macro definition.
> >
> > Signed-off-by: Fabian Frederick <fabf@...net.be>
> > ---
> >   drivers/media/platform/omap/omap_vout.c | 10 +++-------
> >   1 file changed, 3 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/media/platform/omap/omap_vout.c
> > b/drivers/media/platform/omap/omap_vout.c
> > index 17b189a..f09c5f1 100644
> > --- a/drivers/media/platform/omap/omap_vout.c
> > +++ b/drivers/media/platform/omap/omap_vout.c
> > @@ -445,7 +445,7 @@ static int omapvid_init(struct omap_vout_device *vout,
> > u32 addr)
> >     int ret = 0, i;
> >     struct v4l2_window *win;
> >     struct omap_overlay *ovl;
> > -   int posx, posy, outw, outh, temp;
> > +   int posx, posy, outw, outh;
> >     struct omap_video_timings *timing;
> >     struct omapvideo_info *ovid = &vout->vid_info;
> >
> > @@ -468,9 +468,7 @@ static int omapvid_init(struct omap_vout_device *vout,
> > u32 addr)
> >                     /* Invert the height and width for 90
> >                      * and 270 degree rotation
> >                      */
> > -                   temp = outw;
> > -                   outw = outh;
> > -                   outh = temp;
> > +                   swap(outw, outh);
> >                     posy = (timing->y_res - win->w.width) - win->w.left;
> >                     posx = win->w.top;
> >                     break;
> > @@ -481,9 +479,7 @@ static int omapvid_init(struct omap_vout_device *vout,
> > u32 addr)
> >                     break;
> >
> >             case dss_rotation_270_degree:
> > -                   temp = outw;
> > -                   outw = outh;
> > -                   outh = temp;
> > +                   swap(outw, outh);
> >                     posy = win->w.left;
> >                     posx = (timing->x_res - win->w.height) - win->w.top;
> >                     break;
> >
>
>
> Curious to know,
> How do you test this? Do you have any OMAP2/3 or AM335x board?
> Does this driver still works?

Hello Vaibhav,

   Unfortunately I can't test it.
 
Regards,
Fabian
>
> Thanks,
> Vaibhav
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/