linux-kernel - [PATCH 4/4] Staging: lustre: sparse lock warning fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1431974091-26363-5-git-send-email-adrianremonda@gmail.com>
Date:	Mon, 18 May 2015 20:34:51 +0200
From:	Adrian Remonda <adrianremonda@...il.com>
To:	unlisted-recipients:; (no To-header on input)
Cc:	Adrian Remonda <adrianremonda@...il.com>,
	Oleg Drokin <oleg.drokin@...el.com>,
	Andreas Dilger <andreas.dilger@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Julia Lawall <Julia.Lawall@...6.fr>,
	Joe Perches <joe@...ches.com>,
	Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
	Greg Donald <gdonald@...il.com>,
	HPDD-discuss@...ts.01.org (moderated list:STAGING - LUSTRE...),
	devel@...verdev.osuosl.org (open list:STAGING SUBSYSTEM),
	linux-kernel@...r.kernel.org (open list)
Subject: [PATCH 4/4] Staging: lustre: sparse lock warning fix

Fixed sparse warning: context imbalance in 'nrs_resource_put_safe' -
'different lock contexts for basic block' by releasing the lock on each
iteration of the for loop.

Signed-off-by: Adrian Remonda <adrianremonda@...il.com>
---
 drivers/staging/lustre/lustre/ptlrpc/nrs.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/lustre/lustre/ptlrpc/nrs.c b/drivers/staging/lustre/lustre/ptlrpc/nrs.c
index 43da95f0bce2..3a1722437ca1 100644
--- a/drivers/staging/lustre/lustre/ptlrpc/nrs.c
+++ b/drivers/staging/lustre/lustre/ptlrpc/nrs.c
@@ -503,13 +503,11 @@ static void nrs_resource_put_safe(struct ptlrpc_nrs_resource **resp)
 
 		if (nrs == NULL) {
 			nrs = pols[i]->pol_nrs;
-			spin_lock(&nrs->nrs_lock);
 		}
+		spin_lock(&nrs->nrs_lock);
 		nrs_policy_put_locked(pols[i]);
-	}
-
-	if (nrs != NULL)
 		spin_unlock(&nrs->nrs_lock);
+	}
 }
 
 /**
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/