linux-kernel - Re: [PATCH v2] Staging: rtl8192u: Fix coding style issues at ieee80211_crypt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1431985821.9328.16.camel@pedrito-laptop>
Date:	Mon, 18 May 2015 23:50:21 +0200
From:	pmarzo <marzo.pedro@...il.com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	gregkh@...uxfoundation.org, navyasri.tech@...il.com,
	dilekuzulmez@...il.com, joe@...ches.com, haticeerturk27@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Staging: rtl8192u: Fix coding style issues at
 ieee80211_crypt_wep.c

On Mon, 2015-05-18 at 21:53 +0530, Sudip Mukherjee wrote:
> On Mon, May 18, 2015 at 07:36:23PM +0200, Pedro Marzo Perez wrote:
> > Merge two pr_debug lines with literal strings splitted across several lines
> > into one single line, simplifying prism2_wep_init error check code.
> > Openning braces should never be in a new line, move them to the end of
> > the previous line.
> > Removed two useless lines at ieee80211_wep_null.
> 
> Like Joe Perches said in your last patch - you are doing too many things
> in a single patch. break it into separate patches each doing a single
> change.
> 
Agree
> > 
> > Signed-off-by: Pedro Marzo Perez <marzo.pedro@...il.com>
> > ---
> >  .../rtl8192u/ieee80211/ieee80211_crypt_wep.c       | 33 ++++++++--------------
> >  1 file changed, 12 insertions(+), 21 deletions(-)
> > 
> > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
> > index 0a17f84..1074916 100644
> > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
> > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
> > @@ -9,6 +9,8 @@
> >   * more details.
> >   */
> >  
> <snip>
> > -
> > +	pr_debug(pr_fmt("could not allocate crypto API arc4\n"));
> this is not right.
Completely agree
Will be fixed at v3

> 
> regards
> sudip



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/