linux-kernel - Re: [PATCH v2] Staging: rtl8192u: Fix coding style issues at ieee80211_crypt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1431979479.2870.66.camel@perches.com>
Date:	Mon, 18 May 2015 13:04:39 -0700
From:	Joe Perches <joe@...ches.com>
To:	pmarzo <marzo.pedro@...il.com>
Cc:	Dan Carpenter <dan.carpenter@...cle.com>,
	gregkh@...uxfoundation.org, navyasri.tech@...il.com,
	dilekuzulmez@...il.com, haticeerturk27@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Staging: rtl8192u: Fix coding style issues at
 ieee80211_crypt_wep.c

On Mon, 2015-05-18 at 23:56 +0200, pmarzo wrote:
> On Mon, 2015-05-18 at 19:15 +0300, Dan Carpenter wrote:
> > On Mon, May 18, 2015 at 07:36:23PM +0200, Pedro Marzo Perez wrote:
> > > Merge two pr_debug lines with literal strings splitted across several lines
> > > into one single line, simplifying prism2_wep_init error check code.
> > > Openning braces should never be in a new line, move them to the end of
> > > the previous line.
> > > Removed two useless lines at ieee80211_wep_null.
> > > 
> > 
> > When Joe said "Some will say this is doing too many things in a single
> > patch." he meant Greg.  Break this up into multiple patches.  Especially
> > now that you've added even more stuff to it.
> > 
> > regards,
> > dan carpenter
> 
> Sorry Joe, English is not my mother tongue and I misunderstand your
> comment, I thought "Some will say this is doing too many things in a
> single patch" did meant "You are on the limit, but it is ok to send it
> in one patch" but I see it really means "please, rewrite this whole crap
> into several patches" :-)

What I meant to say was I don't care as much about mixing
multiple types of fixes in a single patch as others might.

Greg does and generally rejects patches that mix fix types.

My preference is to do _all_ whitespace changes in a single
patch.  If "git diff -w" shows no source code changes, and
objdiff shows no object code change, that's a "single type"
of change to me.

Others disagree and may want whitespace changes broken down
into finer-grained blocks.

I think it's not necessary to modify the same line multiple
times just to get this granularity.

btw: using:

$ ./scripts/checkpatch.pl -f --strict --fix-inplace \
   --types=spacing,space_before_tab,pointer_location,trailing_whitespace,bracket_space,space_before_tab,indented_label,parenthesis_alignment \
   $file

can do this moderately well and there's a trivial script to
use checkpatch and git to create a patch series for various
checkpatch type style messages.

https://lkml.org/lkml/2014/7/11/794


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/