linux-kernel - Re: [RFC PATCH v3 02/37] perf tools: Set vmlinux_path__nr_entries to 0 in vmlinux_path_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150518202858.GE18563@kernel.org>
Date:	Mon, 18 May 2015 17:28:58 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Alexei Starovoitov <ast@...mgrid.com>
Cc:	Wang Nan <wangnan0@...wei.com>, paulus@...ba.org,
	a.p.zijlstra@...llo.nl, mingo@...hat.com, namhyung@...nel.org,
	jolsa@...nel.org, dsahern@...il.com, daniel@...earbox.net,
	brendan.d.gregg@...il.com, masami.hiramatsu.pt@...achi.com,
	lizefan@...wei.com, linux-kernel@...r.kernel.org, pi3orama@....com
Subject: Re: [RFC PATCH v3 02/37] perf tools: Set vmlinux_path__nr_entries to
 0 in vmlinux_path__exit

Em Mon, May 18, 2015 at 10:01:56AM -0700, Alexei Starovoitov escreveu:
> On 5/17/15 3:56 AM, Wang Nan wrote:
> >Original vmlinux_path__exit() doesn't revert vmlinux_path__nr_entries
> >to its original state. After the while loop vmlinux_path__nr_entries
> >becomes -1 instead of 0. This makes a problem that, if runs twice,
> >during the second run vmlinux_path__init() will set vmlinux_path[-1]
> >to strdup("vmlinux"), corrupts random memory.
> >
> >This patch reset vmlinux_path__nr_entries to 0 after the while loop.
> >
> >Signed-off-by: Wang Nan <wangnan0@...wei.com>
> >Acked-by: Namhyung Kim <namhyung@...nel.org>
> 
> no need to repost. Arnaldo picked it up already.

Yeah, I try to cherry pick stuff that is not related to the main topic
of a patchkit and that is an independent bug fix.

- Arnaldo

> When you repost it many times, it gets very confusing.
> If patch is not moving, rather ping it in original thread.
> Same with patches 3,4,5.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/