linux-kernel - Re: [RFC PATCH v3 23/37] bpf tools: Introduce bpf_load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150518203743.GI18563@kernel.org>
Date:	Mon, 18 May 2015 17:37:43 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Alexei Starovoitov <ast@...mgrid.com>
Cc:	Wang Nan <wangnan0@...wei.com>, paulus@...ba.org,
	a.p.zijlstra@...llo.nl, mingo@...hat.com, namhyung@...nel.org,
	jolsa@...nel.org, dsahern@...il.com, daniel@...earbox.net,
	brendan.d.gregg@...il.com, masami.hiramatsu.pt@...achi.com,
	lizefan@...wei.com, linux-kernel@...r.kernel.org, pi3orama@....com
Subject: Re: [RFC PATCH v3 23/37] bpf tools: Introduce bpf_load_program() to
 bpf.c

Em Mon, May 18, 2015 at 11:52:59AM -0700, Alexei Starovoitov escreveu:
> On 5/17/15 3:56 AM, Wang Nan wrote:
> >bpf_load_program() can be used to load bpf program into kernel. To make
> >loading faster, first try to load without logbuf. Try again with logbuf
> >if the first try failed.
> >
> >Signed-off-by: Wang Nan <wangnan0@...wei.com>
> ...
> >+	attr.insn_cnt = (__u32)insns_cnt;
> >+	attr.insns = ptr_to_u64((void *) insns);
> >+	attr.license = ptr_to_u64((void *) license);
> 
> unnecessary casts?

And inconsistent at that, we don't need a space before the casted
variable.
 
> >+	attr.log_buf = ptr_to_u64(NULL);
> >+	attr.log_size = 0;
> >+	attr.log_level = 0;
> >+	attr.kern_version = kern_version;
> >+
> >+	fd = sys_bpf(BPF_PROG_LOAD, &attr, sizeof(attr));
> >+	if ((fd >= 0) || !log_buf || !log_buf_sz)
> 
> unnecessary ()
> 
> >+		return fd;
> >+
> >+	/* Try again with log */
> >+	attr.log_buf = ptr_to_u64(log_buf);
> >+	attr.log_size = log_buf_sz;
> >+	attr.log_level = 1;
> >+	log_buf[0] = 0;
> >+	return sys_bpf(BPF_PROG_LOAD, &attr, sizeof(attr));
> 
> this part looks good. thank you for addressing the feedback from v1.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/