linux-kernel - Re: [PATCH v2] Staging: rtl8192u: Fix coding style issues at ieee80211_crypt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 May 2015 00:06:16 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	pmarzo <marzo.pedro@...il.com>
Cc:	devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
	haticeerturk27@...il.com, linux-kernel@...r.kernel.org,
	joe@...ches.com, dilekuzulmez@...il.com, navyasri.tech@...il.com
Subject: Re: [PATCH v2] Staging: rtl8192u: Fix coding style issues at
 ieee80211_crypt_wep.c

On Mon, May 18, 2015 at 11:56:08PM +0200, pmarzo wrote:
> On Mon, 2015-05-18 at 19:15 +0300, Dan Carpenter wrote:
> > On Mon, May 18, 2015 at 07:36:23PM +0200, Pedro Marzo Perez wrote:
> > > Merge two pr_debug lines with literal strings splitted across several lines
> > > into one single line, simplifying prism2_wep_init error check code.
> > > Openning braces should never be in a new line, move them to the end of
> > > the previous line.
> > > Removed two useless lines at ieee80211_wep_null.
> > > 
> > 
> > When Joe said "Some will say this is doing too many things in a single
> > patch." he meant Greg.  Break this up into multiple patches.  Especially
> > now that you've added even more stuff to it.
> > 
> > regards,
> > dan carpenter
> 
> Sorry Joe, English is not my mother tongue and I misunderstand your
> comment, I thought "Some will say this is doing too many things in a
> single patch" did meant "You are on the limit, but it is ok to send it
> in one patch" but I see it really means "please, rewrite this whole crap
> into several patches" :-)

The line is a fuzzy line.  You were maybe on the line, maybe but then
you crossed over.

> 
> So I guess an v3 patch should be a chain of several patches, I think a
> sensible approach would be three patches
>   1/3 => rewrite of the error check code
>   2/3 => remove of the two useless lines at ieee80211_wep_null.
>   3/3 => move openning braces and correct the indentation of the
> #include
> 
> What do you think about it?

That sounds fine.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/