linux-kernel - Re: [PATCH 14/19] x86, mpx: new directory entry to addr helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1505182308040.4225@nanos>
Date:	Mon, 18 May 2015 23:10:50 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Dave Hansen <dave@...1.net>
cc:	linux-kernel@...r.kernel.org, x86@...nel.org,
	dave.hansen@...ux.intel.com
Subject: Re: [PATCH 14/19] x86, mpx: new directory entry to addr helper

On Fri, 8 May 2015, Dave Hansen wrote:
> Currently, to get from a bounds directory entry to the virtual
> address of a bounds table, we simply mask off a few low bits.
> However, the set of bits we mask off is different for 32 and
> 64-bit binaries.
> 
> This breaks the operation out in to a helper function and also
> adds a temporary variable to store the result until we are
> sure we are returning one.
> 
> Signed-off-by: Dave Hansen <dave.hansen@...ux.intel.com>

> +static unsigned long mpx_bd_entry_to_bt_addr(struct mm_struct *mm,
> +		unsigned long bd_entry)

Nit: Please adjust the second line so the arguments are horizontally
aligned.

static unsigned long mpx_bd_entry_to_bt_addr(struct mm_struct *mm,
		     			     unsigned long bd_entry)

Aside of that: Reviewed-by: Thomas Gleixner <tglx@...utronix.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/