linux-kernel - Re: [PATCH] x86, cpuinfo fix cpu_data(0) x86_model

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <555A61DB.90608@redhat.com>
Date:	Mon, 18 May 2015 18:04:11 -0400
From:	Prarit Bhargava <prarit@...hat.com>
To:	"H. Peter Anvin" <hpa@...or.com>
CC:	Borislav Petkov <bp@...en8.de>, Brian Gerst <brgerst@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	the arch/x86 maintainers <x86@...nel.org>,
	Andy Lutomirski <luto@...capital.net>,
	Denys Vlasenko <dvlasenk@...hat.com>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>,
	Igor Mammedov <imammedo@...hat.com>,
	Fenghua Yu <fenghua.yu@...el.com>
Subject: Re: [PATCH] x86, cpuinfo fix cpu_data(0) x86_model_id field truncation



On 05/18/2015 04:53 PM, H. Peter Anvin wrote:
> On 05/18/2015 01:36 PM, Borislav Petkov wrote:
>> On Mon, May 18, 2015 at 04:27:02PM -0400, Brian Gerst wrote:
>>> The problem here is that strim() modifies the string in place,
>>> replacing the first trailing space with a null.  I think the best
>>> solution is to do the trimming in get_model_name().  It already trims
>>> leading spaces for Intel.
>>
>> Sounds good - start from the 48th position forward to the first non \s
>> char. Yeah.
>>
> 
> Yes, we should trim both leading and trailing spaces.

Oh sorry, I missed this as it just landed in my mailbox.  So a backward search
for the first non \s char.

I can do that and I'll nack my new patch.

P.

> 
> 	-hpa
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/