linux-kernel - Re: [PATCH v8 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150519194917.GI24769@pengutronix.de>
Date:	Tue, 19 May 2015 21:49:17 +0200
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	Matthias Brugger <matthias.bgg@...il.com>
Cc:	Mark Rutland <mark.rutland@....com>,
	Xudong Chen <xudong.chen@...iatek.com>,
	srv_heupstream <srv_heupstream@...iatek.com>,
	Pawel Moll <pawel.moll@....com>,
	Wolfram Sang <wsa@...-dreams.de>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Liguo Zhang <liguo.zhang@...iatek.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Rob Herring <robh+dt@...nel.org>,
	linux-mediatek@...ts.infradead.org, linux-i2c@...r.kernel.org,
	Sascha Hauer <kernel@...gutronix.de>,
	Kumar Gala <galak@...eaurora.org>,
	Eddie Huang <eddie.huang@...iatek.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v8 2/3] I2C: mediatek: Add driver for MediaTek I2C
 controller

Hello Matthias,

On Tue, May 19, 2015 at 04:48:23PM +0200, Matthias Brugger wrote:
> 2015-05-18 20:43 GMT+02:00 Uwe Kleine-König <u.kleine-koenig@...gutronix.de>:
> > On Tue, May 19, 2015 at 12:40:08AM +0800, Eddie Huang wrote:
> >> [...]
> >>  drivers/i2c/busses/i2c-mt65xx.c | 675 ++++++++++++++++++++++++++++++++++++++++
> >> [...]
> >> +#define I2C_DRV_NAME         "mt-i2c"
> > i2c-mt65xx ?
> 
> As this works for all SoCs so far, I would propose: i2c-mtk
Hmm, currently we have:

  - #define I2C_DRV_NAME mt-i2c
  - dt-compatibles: "mediatek,mt6577-i2c" + "mediatek,mt6589-i2c"
  - function prefix: mtk_i2c_
  - filename: i2c-mt65xx.c
  - Kconfig symbol: I2C_MT65XX

Getting some harmonization here would definitly be nice.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/