linux-kernel - Re: [PATCH] x86, cpuinfo x86_model

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1432067178.2870.209.camel@perches.com>
Date:	Tue, 19 May 2015 13:26:18 -0700
From:	Joe Perches <joe@...ches.com>
To:	Andy Lutomirski <luto@...capital.net>
Cc:	Borislav Petkov <bp@...en8.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Fenghua Yu <fenghua.yu@...el.com>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Denys Vlasenko <dvlasenk@...hat.com>,
	Ingo Molnar <mingo@...hat.com>,
	Brian Gerst <brgerst@...il.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Igor Mammedov <imammedo@...hat.com>,
	the arch/x86 maintainers <x86@...nel.org>,
	Prarit Bhargava <prarit@...hat.com>
Subject: Re: [PATCH] x86, cpuinfo x86_model_id whitespace cleanup

iOn Tue, 2015-05-19 at 13:16 -0700, Andy Lutomirski wrote:
> On Tue, May 19, 2015 at 12:22 PM, Borislav Petkov <bp@...en8.de> wrote:
> > On Tue, May 19, 2015 at 11:44:41AM -0700, Andy Lutomirski wrote:
> >> On May 19, 2015 11:13 AM, "Borislav Petkov" <bp@...en8.de> wrote:
> >> >
> >> > On Tue, May 19, 2015 at 01:25:59PM -0400, Brian Gerst wrote:
> >> > > Using strlcpy in this manner could fail if it does larger than byte
> >> > > copies and they overlap.
> >> >
> >> > Why?

I think this is traditionally handled by specifying that
the strcpy strings may not overlap, so the suggested

+	strlcpy(c->x86_model_id, strim(c->x86_model_id), 48);

isn't good code.

A temporary intermediate buffer is required.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/