[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1432075769.20560.4.camel@pedrito-laptop>
Date: Wed, 20 May 2015 00:49:29 +0200
From: pmarzo <marzo.pedro@...il.com>
To: Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc: gregkh@...uxfoundation.org, navyasri.tech@...il.com,
dilekuzulmez@...il.com, joe@...ches.com, haticeerturk27@...il.com,
devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
dan.carpenter@...cle.com
Subject: Re: [PATCH 1/3 v3] Staging: rtl8192u: Simplify error check code at
prism2_wep_init
On Tue, 2015-05-19 at 11:04 +0530, Sudip Mukherjee wrote:
> On Tue, May 19, 2015 at 01:32:22AM +0200, Pedro Marzo Perez wrote:
> > Merge two pr_debug lines with literal strings splitted across several lines
> > into one single line, simplifying prism2_wep_init error check code.
>
> I would have split this patch into three.
> 1) introduce pr_fmt and remove "ieee80211_crypt_wep" from pr_debug
> 2) return NULL instead of that goto fail.
> 3) combine two pr_debug into a single at the fail block.
>
I firmly agree with the "one logical change-one patch" rule but this
seems to me a bit overkilling.Anyway I am a completely newbie sending
kernel patches so you are probably right.
> But Dan can say if its ok. (I am still taking ideas from Dan about my
> patches)
Sure. Dan, we need your wisdom!
>
> regards
> sudip
thanku for your comments sudip!
regards
pedro
> >
> > Signed-off-by: Pedro Marzo Perez <marzo.pedro@...il.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists