linux-kernel - Re: [PATCH 13/40] perf tools: Convert dead thread list into rbtree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150519064500.GI21663@sejong>
Date:	Tue, 19 May 2015 15:45:00 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Andi Kleen <andi@...stfloor.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 13/40] perf tools: Convert dead thread list into rbtree

On Mon, May 18, 2015 at 09:34:25PM +0200, Jiri Olsa wrote:
> On Mon, May 18, 2015 at 09:30:28AM +0900, Namhyung Kim wrote:
> 
> SNIP
> 
> > @@ -38,6 +39,7 @@ struct thread *thread__new(pid_t pid, pid_t tid)
> >  		thread->ppid = -1;
> >  		thread->cpu = -1;
> >  		INIT_LIST_HEAD(&thread->comm_list);
> > +		INIT_LIST_HEAD(&thread->tid_node);
> >  
> >  		if (unwind__prepare_access(thread) < 0)
> >  			goto err_thread;
> > @@ -54,7 +56,7 @@ struct thread *thread__new(pid_t pid, pid_t tid)
> >  
> >  		list_add(&comm->list, &thread->comm_list);
> >  		atomic_set(&thread->refcnt, 0);
> > -		INIT_LIST_HEAD(&thread->node);
> > +		INIT_LIST_HEAD(&thread->tid_node);
> 
> tid_node is initialized twice

Okay, will fix.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/