linux-kernel - Re: [PATCH 03/19] x86, mpx: use new tsk_get_xsave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 18 May 2015 17:01:17 -0700
From:	Dave Hansen <dave@...1.net>
To:	Thomas Gleixner <tglx@...utronix.de>
CC:	linux-kernel@...r.kernel.org, x86@...nel.org,
	dave.hansen@...ux.intel.com, oleg@...hat.com, bp@...en8.de,
	riel@...hat.com, sbsiddha@...il.com, luto@...capital.net,
	mingo@...hat.com, hpa@...or.com, fenghua.yu@...el.com
Subject: Re: [PATCH 03/19] x86, mpx: use new tsk_get_xsave_addr()

On 05/18/2015 01:36 PM, Thomas Gleixner wrote:
>> >  #ifdef CONFIG_X86_INTEL_MPX
>> >  siginfo_t *mpx_generate_siginfo(struct pt_regs *regs,
>> > -				struct xsave_struct *xsave_buf);
>> > -int mpx_handle_bd_fault(struct xsave_struct *xsave_buf);
>> > +				struct task_struct *tsk);
>> > +int mpx_handle_bd_fault(struct task_struct *tsk);
> So you still keep *tsk and remove it in the next patch. I guess either
> ordering has its value, so no problem to do it this way.

I agree that this looks a bit goofy.

Originally, this patch just passed around 'tsk' instead of 'xsave_buf'.
 But I realized we could go a step further.

The way it stands, it is bisectable and been built in this configuration
for a month or two.  I'd really like to keep it this way if possible,
even though it looks a bit goofy.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/