| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <555B098A.8030202@linaro.org> Date: Tue, 19 May 2015 11:59:38 +0200 From: Daniel Lezcano <daniel.lezcano@...aro.org> To: Maxime Coquelin <mcoquelin.stm32@...il.com> CC: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>, Andreas Färber <afaerber@...e.de>, Geert Uytterhoeven <geert@...ux-m68k.org>, Rob Herring <robh+dt@...nel.org>, Philipp Zabel <p.zabel@...gutronix.de>, Linus Walleij <linus.walleij@...aro.org>, Arnd Bergmann <arnd@...db.de>, Stefan Agner <stefan@...er.ch>, Peter Meerwald <pmeerw@...erw.net>, Paul Bolle <pebolle@...cali.nl>, Peter Hurley <peter@...leysoftware.com>, Andy Shevchenko <andy.shevchenko@...il.com>, Chanwoo Choi <cw00.choi@...sung.com>, Russell King <linux@....linux.org.uk>, Joe Perches <joe@...ches.com>, Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com>, Lee Jones <lee.jones@...aro.org>, Daniel Thompson <daniel.thompson@...aro.org>, Jonathan Corbet <corbet@....net>, Pawel Moll <pawel.moll@....com>, Mark Rutland <mark.rutland@....com>, Ian Campbell <ijc+devicetree@...lion.org.uk>, Kumar Gala <galak@...eaurora.org>, Thomas Gleixner <tglx@...utronix.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jiri Slaby <jslaby@...e.cz>, Andrew Morton <akpm@...ux-foundation.org>, "David S. Miller" <davem@...emloft.net>, Mauro Carvalho Chehab <mchehab@....samsung.com>, Antti Palosaari <crope@....fi>, Tejun Heo <tj@...nel.org>, Will Deacon <will.deacon@....com>, Nikolay Borisov <Nikolay.Borisov@....com>, Rusty Russell <rusty@...tcorp.com.au>, Kees Cook <keescook@...omium.org>, Michal Marek <mmarek@...e.cz>, "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>, "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>, Linux-Arch <linux-arch@...r.kernel.org>, "linux-api@...r.kernel.org" <linux-api@...r.kernel.org>, Nicolae Rosia <nicolae.rosia@...il.com>, Kamil Lulko <rev13@...pl> Subject: Re: [PATCH v8 09/16] clockevents/drivers: Add STM32 Timer driver On 05/19/2015 11:44 AM, Maxime Coquelin wrote: > 2015-05-19 11:06 GMT+02:00 Daniel Lezcano <daniel.lezcano@...aro.org>: >> On 05/19/2015 10:55 AM, Maxime Coquelin wrote: >>> >>> 2015-05-19 10:16 GMT+02:00 Daniel Lezcano <daniel.lezcano@...aro.org>: >>>> >>>> On 05/18/2015 04:03 PM, Maxime Coquelin wrote: >>>>> >>>>> >>>>> 2015-05-18 15:10 GMT+02:00 Daniel Lezcano <daniel.lezcano@...aro.org>: >>>>>> >>>>>> >>>>>> On 05/09/2015 09:53 AM, Maxime Coquelin wrote: >>>>>>> >>>>>>> >>>>>>> >>>>>>> STM32 MCUs feature 16 and 32 bits general purpose timers with >>>>>>> prescalers. >>>>>>> The drivers detects whether the time is 16 or 32 bits, and applies a >>>>>>> 1024 prescaler value if it is 16 bits. >>>>>>> >>>>>>> Reviewed-by: Linus Walleij <linus.walleij@...aro.org> >>>>>>> Tested-by: Chanwoo Choi <cw00.choi@...sung.com> >>>>>>> Signed-off-by: Maxime Coquelin <mcoquelin.stm32@...il.com> >>>>>>> --- >>>>>>> drivers/clocksource/Kconfig | 8 ++ >>>>>>> drivers/clocksource/Makefile | 1 + >>>>>>> drivers/clocksource/timer-stm32.c | 184 >>>>>>> ++++++++++++++++++++++++++++++++++++++ >>>>>>> 3 files changed, 193 insertions(+) >>>>>>> create mode 100644 drivers/clocksource/timer-stm32.c >>>>>>> >>>>>>> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig >>>>>>> index bf9364c..2443520 100644 >>>>>>> --- a/drivers/clocksource/Kconfig >>>>>>> +++ b/drivers/clocksource/Kconfig >>>>>>> @@ -106,6 +106,14 @@ config CLKSRC_EFM32 >>>>>>> Support to use the timers of EFM32 SoCs as clock source >>>>>>> and >>>>>>> clock >>>>>>> event device. >>>>>>> >>>>>>> +config CLKSRC_STM32 >>>>>>> + bool "Clocksource for STM32 SoCs" if !ARCH_STM32 >>>>>>> + depends on OF && ARM && (ARCH_STM32 || COMPILE_TEST) >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> Are the interactive bool and the 'COMPILE_TEST' necessary ? >>>>>> >>>>> >>>>> The interactive bool is necessary if we want to be able to >>>>> select/deselect it in COMPILE_TEST configuration. >>>>> And personnaly, I think COMPILE_TEST use makes sense. >>>>> >>>>> Note that other timer drivers are doing the same thing today >>>>> (CLKSRC_EFM32, SH_TIMER_CMT, EM_TIMER_STI...). >>>>> >>>>> Do you have a specific concern regarding COMPILE_TEST? >>>> >>>> >>>> >>>> Actually, we try to keep the timer selection non-interactive and let the >>>> platform's Kconfig to select the timer. >>> >>> >>> Ok. >>> >>>> >>>> I like when the code is consistent. The COMPILE_TEST was introduced and >>>> created a precedence. I would like to get rid of the interactive timer >>>> selection but I did not have time to go through this yet. >>> >>> >>> Indeed, consistency is important. >>> On my side, I don't have a strong opinion regarding the COMPILE_TEST >>> thing. >>> IMHO, it is more a subsystem's maintainer choice. >>> >>> So, if as a maintainer you don't use it and prefer not supporting it, >>> I'm fine to provide you a new version without COMPILE_TEST. >>> Doing that, the interactive selection will disappear too. >>> >>> I can provide you a new version this evenning. >> >> >> Ok, great. > > Is the below Kconfig entry fine for you? > > config CLKSRC_STM32 > def_bool y if ARCH_STM32 > select CLKSRC_MMIO config CLKSRC_STM32 bool select CLKSRC_MMIO and in the arch/arm/mach-stm32/Kconfig add select CLKSRC_STM32 > Best regards, > Maxime > > >> >> Thanks >> -- Daniel >> >> >>>> >>>> >>>> >>>> -- >>>> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs >>>> >>>> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | >>>> <http://twitter.com/#!/linaroorg> Twitter | >>>> <http://www.linaro.org/linaro-blog/> Blog >>>> >> >> >> -- >> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs >> >> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | >> <http://twitter.com/#!/linaroorg> Twitter | >> <http://www.linaro.org/linaro-blog/> Blog >> -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists