[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150519111827.GM22558@mwanda>
Date: Tue, 19 May 2015 14:18:27 +0300
From: Dan Carpenter <dan.carpenter@...cle.com>
To: Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc: Greg KH <gregkh@...uxfoundation.org>,
One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>,
Jean Delvare <jdelvare@...e.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 WIP 2/5] staging: panel: use new parport device model
On Wed, May 06, 2015 at 03:46:14PM +0530, Sudip Mukherjee wrote:
> converted to use the new device-model parallel port.
>
> Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
> ---
> drivers/staging/panel/panel.c | 20 +++++++++++++++-----
> 1 file changed, 15 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
> index 1d8ed8b..772a82a 100644
> --- a/drivers/staging/panel/panel.c
> +++ b/drivers/staging/panel/panel.c
> @@ -2188,6 +2188,18 @@ static struct notifier_block panel_notifier = {
> 0
> };
>
> +static int panel_probe(struct pardevice *par_dev)
> +{
> + if (strcmp(par_dev->name, "panel"))
> + return -ENODEV;
> + return 0;
> +}
> +
> +struct pardev_cb panel_cb = {
> + .flags = 0, /*PARPORT_DEV_EXCL */
I don't understand this comment. PARPORT_DEV_EXCL is BIT(2). Update:
Oh, I see this comment is just copied from the earlier code and probably
means that it maybe should be set to PARPORT_DEV_EXCL. Just put
something like this:
.flags = 0, /* should be PARPORT_DEV_EXCL? */
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists