linux-kernel - Re: [PATCH v4 3/7] mmc: mediatek: Add PM support for MMC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFo=f-8aycE9wPjdWEjdVLLz8Lk=Pt2=JeTL3CSM-2Gj4g@mail.gmail.com>
Date:	Tue, 19 May 2015 13:55:29 +0200
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Sascha Hauer <s.hauer@...gutronix.de>
Cc:	Chaotian Jing <chaotian.jing@...iatek.com>,
	Rob Herring <robh+dt@...nel.org>,
	Matthias Brugger <matthias.bgg@...il.com>,
	Chris Ball <chris@...ntf.net>,
	Mark Rutland <mark.rutland@....com>,
	James Liao <jamesjj.liao@...iatek.com>,
	srv_heupstream <srv_heupstream@...iatek.com>,
	Arnd Bergmann <arnd@...db.de>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Hongzhou Yang <hongzhou.yang@...iatek.com>,
	Catalin Marinas <catalin.marinas@....com>,
	Bin Zhang (章斌) <bin.zhang@...iatek.com>,
	linux-mmc <linux-mmc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Will Deacon <will.deacon@....com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	linux-mediatek@...ts.infradead.org,
	Sascha Hauer <kernel@...gutronix.de>,
	"Joe.C" <yingjoe.chen@...iatek.com>,
	Eddie Huang <eddie.huang@...iatek.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v4 3/7] mmc: mediatek: Add PM support for MMC driver

On 19 May 2015 at 13:04, Sascha Hauer <s.hauer@...gutronix.de> wrote:
> Hi Chaotian,
>
> On Tue, May 19, 2015 at 02:36:47PM +0800, Chaotian Jing wrote:
>> Add PM support for Mediatek MMC driver
>> Save/restore registers when PM
>
> Has anyone asked you to add a new driver in two steps? I find it hard to
> review if a driver is introduced and changed right afterwards.
> Presumably you find it hard to maintain the patches like this also.
> Please ignore if this is indeed requested by someone.

I requested it.

Primarily because I want to make sure we deal with runtime/system PM
support properly. I guess I have seen too many cases where
functionality is broken, unless compiled with CONFIG_PM* set.

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/