linux-kernel - Re: [PATCH v3 1/2] serial_core: add pci uart early console support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1432036867.9091.75.camel@x220>
Date:	Tue, 19 May 2015 14:01:07 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Bin Gao <bin.gao@...ux.intel.com>
Cc:	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
	Peter Hurley <peter@...leysoftware.com>,
	Jiri Slaby <jslaby@...e.cz>
Subject: Re: [PATCH v3 1/2] serial_core: add pci uart early console support

On Mon, 2015-05-18 at 14:21 -0700, Bin Gao wrote:
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -2228,6 +2228,8 @@ config PCI
>  	  your box. Other bus systems are ISA, EISA, MicroChannel (MCA) or
>  	  VESA. If you have PCI, say Y, otherwise N.
>  
> +	select HAVE_EARLY_PCI
> +

It's legal to have options after the help text of a Kconfig entry. It's
also very uncommon to do that. Please put this select statement before
the line reading "---help---" of the PCI entry.
 
> +config HAVE_EARLY_PCI
> +	def_bool y

You probably want just
	bool

here. Because this symbol has no further dependencies, which means
HAVE_EARLY_PCI will now always be set to 'y'. That, in turn, makes the
select you added above pointless.

> +	help
> +	  This option indicates that a group of APIs are available (in
> +	  asm/pci-direct.h) so the kernel can access pci config registers
> +	  before the PCI subsystem is initialized. Any arch that supports

Is this expected to be used outside of X86?

> +	  early pci APIs must enable this option which is required  by arch
> +	  independent codes, e.g. uart8250 pci early console driver.
> +

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/