linux-kernel - [PATCH] input: sur40: fix v4l dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <6880566.G7eZ6NqpSp@wuerfel>
Date:	Tue, 19 May 2015 15:08:05 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Hans Verkuil <hans.verkuil@...co.com>,
	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	Florian Echtler <floe@...terbrot.org>,
	Henrik Rydberg <rydberg@...math.org>,
	linux-arm-kernel@...ts.infradead.org
Subject: [PATCH] input: sur40: fix v4l dependency

The recently added support for the raw video stream in the SUR40
driver fails to link if the driver is built-in but v4l2 is not:

drivers/built-in.o: In function `sur40_disconnect':
:(.text+0xf2ed2): undefined reference to `video_unregister_device'
:(.text+0xf2eda): undefined reference to `v4l2_device_unregister'
:(.text+0xf2ee2): undefined reference to `vb2_dma_sg_cleanup_ctx'

This adds an explicit dependency, to avoid the broken build.

Signed-off-by: Arnd Bergmann <arnd@...db.de>
Fixes: e831cd251fb ("[media] add raw video stream support for Samsung SUR40")

diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
index cee8ffe4ffd9..90935f3918db 100644
--- a/drivers/input/touchscreen/Kconfig
+++ b/drivers/input/touchscreen/Kconfig
@@ -980,6 +980,7 @@ config TOUCHSCREEN_SUN4I
 config TOUCHSCREEN_SUR40
 	tristate "Samsung SUR40 (Surface 2.0/PixelSense) touchscreen"
 	depends on USB && MEDIA_USB_SUPPORT && HAS_DMA
+	depends on VIDEO_V4L2
 	select INPUT_POLLDEV
 	select VIDEOBUF2_DMA_SG
 	help

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/