linux-kernel - Re: [PATCH] ARM: multi_v7_defconfig: Add Atmel SAMA5 family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 May 2015 15:28:50 +0200
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	Arnd Bergmann <arnd@...db.de>
CC:	Olof Johansson <olof@...om.net>,
	Boris BREZILLON <boris.brezillon@...e-electrons.com>,
	<linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	Kevin Hilman <khilman@...nel.org>
Subject: Re: [PATCH] ARM: multi_v7_defconfig: Add Atmel SAMA5 family

Le 19/05/2015 15:02, Nicolas Ferre a écrit :
> Le 19/05/2015 14:33, Alexandre Belloni a écrit :
>> On 19/05/2015 at 13:04:22 +0200, Arnd Bergmann wrote :
>>>>> @@ -250,15 +261,18 @@ CONFIG_SERIAL_FSL_LPUART=y
>>>>>  CONFIG_SERIAL_FSL_LPUART_CONSOLE=y
>>>>>  CONFIG_SERIAL_ST_ASC=y
>>>>>  CONFIG_SERIAL_ST_ASC_CONSOLE=y
>>>>> +CONFIG_HW_RANDOM=y
>>>>>  CONFIG_I2C_CHARDEV=y
>>>>>  CONFIG_I2C_DAVINCI=y
>>>>>  CONFIG_I2C_MUX=y
>>>
>>> seems non-essential.
>>>
>>
>> That is an oversight, it should be compiled as a module.
> 
> Ok, I modify it: no need to bother sending a new revision.
> 
>>>>> @@ -502,6 +522,8 @@ CONFIG_RTC_DRV_MV=y
>>>>>  CONFIG_RTC_DRV_TEGRA=y
>>>>>  CONFIG_DMADEVICES=y
>>>>>  CONFIG_DW_DMAC=y
>>>>> +CONFIG_AT_HDMAC=y
>>>>> +CONFIG_AT_XDMAC=y
>>>>>  CONFIG_MV_XOR=y
>>>>>  CONFIG_TEGRA20_APB_DMA=y
>>>>>  CONFIG_SH_DMAE=y
>>>
>>> What are these required for? I assume you need them for MMC? If so, that's
>>> fine.
>>>
>>
>> That is indeed the reason.
> 
> Yep.
> 
> So I simply do a s/y/m/ on the CONFIG_HW_RANDOM then included it in our
> at91-4.2-defconfig branch.

In fact it's a boolean. So removing it does the trick.

Bye,
-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/