linux-kernel - Re: [PATCH] perf: fix wrong DEBUG configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150519140422.GJ13946@kernel.org>
Date:	Tue, 19 May 2015 11:04:22 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Martin Liška <mliska@...e.cz>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH] perf: fix wrong DEBUG configuration

Em Tue, May 19, 2015 at 03:41:03PM +0200, Martin Liška escreveu:
> Following patch is fix for wrong DEBUG configuration.

Can you please state, in the changelog, what you think is wrong and how
your proposed change fixes it, so that after reading your intent I can
go and look at the code to see if it matches that?

- Arnaldo
 
> Signed-off-by: Martin Liska <mliska@...e.cz>
> ---
>  tools/perf/arch/common.c            | 2 +-
>  tools/perf/config/Makefile          | 2 +-
>  tools/perf/util/symbol.c            | 2 +-
>  tools/perf/util/trace-event-parse.c | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/perf/arch/common.c b/tools/perf/arch/common.c
> index 49776f1..b7bb42c 100644
> --- a/tools/perf/arch/common.c
> +++ b/tools/perf/arch/common.c
> @@ -61,7 +61,7 @@ const char *const mips_triplets[] = {
>  static bool lookup_path(char *name)
>  {
>  	bool found = false;
> -	char *path, *tmp;
> +	char *path, *tmp = NULL;
>  	char buf[PATH_MAX];
>  	char *env = getenv("PATH");
> diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
> index 59a98c6..b708ae0 100644
> --- a/tools/perf/config/Makefile
> +++ b/tools/perf/config/Makefile
> @@ -129,7 +129,7 @@ ifndef DEBUG
>  endif
>  ifeq ($(DEBUG),0)
> -  CFLAGS += -O6
> +  CFLAGS += -Og
>  endif
>  ifdef PARSER_DEBUG
> diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
> index 201f6c4c..29792d2 100644
> --- a/tools/perf/util/symbol.c
> +++ b/tools/perf/util/symbol.c
> @@ -397,7 +397,7 @@ static struct symbol *symbols__find_by_name(struct rb_root *symbols,
>  					    const char *name)
>  {
>  	struct rb_node *n;
> -	struct symbol_name_rb_node *s;
> +	struct symbol_name_rb_node *s = NULL;
>  	if (symbols == NULL)
>  		return NULL;
> diff --git a/tools/perf/util/trace-event-parse.c b/tools/perf/util/trace-event-parse.c
> index 25d6c73..d495741 100644
> --- a/tools/perf/util/trace-event-parse.c
> +++ b/tools/perf/util/trace-event-parse.c
> @@ -173,7 +173,7 @@ void parse_ftrace_printk(struct pevent *pevent,
>  	char *line;
>  	char *next = NULL;
>  	char *addr_str;
> -	char *fmt;
> +	char *fmt = NULL;
>  	line = strtok_r(file, "\n", &next);
>  	while (line) {
> -- 
> 2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/