linux-kernel - Re: [PATCH v6 1/2] PCI/MSI: Don't disable MSI/MSI-X at shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150519145853.GP31666@google.com>
Date:	Tue, 19 May 2015 09:58:53 -0500
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	"Michael S. Tsirkin" <mst@...hat.com>
Cc:	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
	Fam Zheng <famz@...hat.com>,
	Yinghai Lu <yhlu.kernel.send@...il.com>,
	Yijing Wang <wangyijing@...wei.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Ulrich Obergfell <uobergfe@...hat.com>,
	Rusty Russell <rusty@...tcorp.com.au>
Subject: Re: [PATCH v6 1/2] PCI/MSI: Don't disable MSI/MSI-X at shutdown

On Tue, May 12, 2015 at 03:03:32PM +0200, Michael S. Tsirkin wrote:
> d52877c7b1af ("pci/irq: let pci_device_shutdown to call pci_msi_shutdown
> v2") disabled MSI/MSI-X at device shutdown to address a kexec problem.
> ... 

I know you're trying to put all the justification in the changelog, and
that's great if it can be done.  But would you please just add the single
link here to https://bugzilla.kernel.org/show_bug.cgi?id=96571 ?

And please attach the dmesg log and instructions for reproducing the
problem to the bugzilla.  I've asked for this before, and it seems like a
simple request, but maybe there's a reason it's more complicated than it
seems to me.  It's obvious to you how all this fits together, but I'd like
it to be more concrete to the rest of us, too.

The bugzilla says Ulrich Obergfell noticed this in RHEL7.  If there's a
RHEL bugzilla, it'd be nice to have a link to it in the kernel.org
bugzilla.  Informal hints are great right now, but they'll be useless after
six months.

Bjorn

> Reported-by: Fam Zheng <famz@...hat.com>
> Tested-by: Fam Zheng <famz@...hat.com>
> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>
> CC: Yinghai Lu <yhlu.kernel.send@...il.com>
> CC: Ulrich Obergfell <uobergfe@...hat.com>
> CC: Rusty Russell <rusty@...tcorp.com.au>
> ---
>  drivers/pci/pci-driver.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c
> index 3cb2210..38a602c 100644
> --- a/drivers/pci/pci-driver.c
> +++ b/drivers/pci/pci-driver.c
> @@ -450,8 +450,6 @@ static void pci_device_shutdown(struct device *dev)
>  
>  	if (drv && drv->shutdown)
>  		drv->shutdown(pci_dev);
> -	pci_msi_shutdown(pci_dev);
> -	pci_msix_shutdown(pci_dev);
>  
>  #ifdef CONFIG_KEXEC
>  	/*
> -- 
> MST
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/