linux-kernel - Re: [PATCH v3 0/4] firmware: few fixes for name uses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150519164533.GF23057@wotan.suse.de>
Date:	Tue, 19 May 2015 18:45:33 +0200
From:	"Luis R. Rodriguez" <mcgrof@...e.com>
To:	ming.lei@...onical.com, gregkh@...uxfoundation.org, tiwai@...e.de
Cc:	rusty@...tcorp.com.au, torvalds@...ux-foundation.org,
	dhowells@...hat.com, seth.forshee@...onical.com,
	linux-kernel@...r.kernel.org, pebolle@...cali.nl,
	linux-wireless@...r.kernel.org, gregkh@...uxfoundation.org,
	jlee@...e.com, tiwai@...e.de,
	"Luis R. Rodriguez" <mcgrof@...not-panic.com>
Subject: Re: [PATCH v3 0/4] firmware: few fixes for name uses

On Tue, May 12, 2015 at 02:49:39PM -0700, Luis R. Rodriguez wrote:
> From: "Luis R. Rodriguez" <mcgrof@...e.com>
> 
> This v3 changes patch 1 to just return -ENOMEM and remove the
> unlikely() optimization. It also drops the early truncation
> checks.
> 
> Luis R. Rodriguez (4):
>   firmware: fix __getname() missing failure check
>   firmware: check for file truncation on direct firmware loading
>   firmware: fix possible use after free on name on asynchronous request
>   firmware: use const for remaining firmware names
> 
>  drivers/base/firmware_class.c | 61 +++++++++++++++++++++++++++++++------------
>  1 file changed, 45 insertions(+), 16 deletions(-)

Ming, a review would be much appreciated. I also have a few other changes coming
later, so should these go through Greg or Takashi first ? If its of any help
I'm happy to take on co-maintenance on this module given that I am lookng
to do quite a bit of surgery on the APIs later.

 Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/