linux-kernel - Re: Audio crackles with 4.1-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hr3qctryf.wl-tiwai@suse.de>
Date:	Tue, 19 May 2015 19:09:12 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Jonathan McDowell <noodles@...th.li>
Cc:	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: Audio crackles with 4.1-rc1

At Tue, 19 May 2015 17:19:11 +0100,
Jonathan McDowell wrote:
> 
> On Tue, May 19, 2015 at 08:15:32AM +0200, Takashi Iwai wrote:
> > At Sat, 2 May 2015 16:05:13 +0100,
> > Jonathan McDowell wrote:
> > > 
> > > On Thu, Apr 30, 2015 at 07:06:31PM +0200, Takashi Iwai wrote:
> > > > At Thu, 30 Apr 2015 16:01:31 +0100, Jonathan McDowell wrote:
> > > > > 
> > > > > On Wed, Apr 29, 2015 at 01:54:57PM +0200, Takashi Iwai wrote:
> > > > > > 
> > > > > > One patch you can try (with or without power_save_node
> > > > > > disablement) is below, it squashes the verb sequences at (runtime)
> > > > > > PM resume as we did for 4.0.  Let me know if this changes the
> > > > > > behavior.
> > > > > 
> > > > > Patch alone has no effect. Patch with power_save_node disablement
> > > > > solves the problem. Didn't try power_save_node disablement without
> > > > > the patch.
> > > > 
> > > > Then please confirm that only power_save_node disablement suffices.
> > > > This can be considered as the least change that can be put to 4.1-rc
> > > > if no better fix is found.
> > > 
> > > Setting codec->power_save_node to 0 in patch_alc269 is sufficient; no
> > > noticeable cracking occurring.
> > 
> > Does the patch below have any improvement?
> 
> I still get a clicking on the standby -> active transition with the
> patch provided on top of 4.1-rc4.

OK, just to be sure, could you check whether changing msleep(10) to
msleep(100) makes no difference?  Also put a line like
	pr_info("XXX power up %x\n", nid);
after msleep() call to see which nodes are powered up dynamically.


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/