linux-kernel - Re: [RFC] block: remove never-modified global variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150519175837.GX11598@ld-irv-0074>
Date:	Tue, 19 May 2015 10:58:37 -0700
From:	Brian Norris <computersforpeace@...il.com>
To:	Boaz Harrosh <boaz@...xistor.com>
Cc:	Jens Axboe <axboe@...com>, linux-kernel@...r.kernel.org,
	Christoph Hellwig <hch@...radead.org>
Subject: Re: [RFC] block: remove never-modified global variable

On Tue, May 19, 2015 at 10:55:32AM -0700, Brian Norris wrote:
> On Tue, May 19, 2015 at 10:34:56AM +0300, Boaz Harrosh wrote:
> > boaz> So by this stage res can only be == 0. So we should just do:
> > 
> >  	if (err)
> > 	/* The partition is unrecognized. So report I/O errors if there were any */
> > -		res = err;
> 
> ^^ You don't want to kill this line, since we still return ERR_PRT(res).
> But otherwise, I think you're right.
> 
> > -	if (res) {
> > -		strlcat(state->pp_buf,
> > -			" unable to read partition table\n", PAGE_SIZE);
> > -		printk(KERN_INFO "%s", state->pp_buf);
> > -	}
> > +		printk(KERN_INFO "%s unable to read partition table\n",
> > +		       state->pp_buf);
> >  
> >  	free_page((unsigned long)state->pp_buf);
> >  	free_partitions(state);
> >  	return ERR_PTR(res);

Or rather, just make the above line:

	return ERR_PTR(err);

> >  }

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/