linux-kernel - Re: [patch -next] target: double locking typo in core_clear_lun_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1432061072.19713.2.camel@haakon3.risingtidesystems.com>
Date:	Tue, 19 May 2015 11:44:32 -0700
From:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	linux-scsi@...r.kernel.org, target-devel@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch -next] target: double locking typo in
 core_clear_lun_from_tpg()

On Tue, 2015-05-19 at 15:04 +0300, Dan Carpenter wrote:
> We accidentally deadlock instead of unlocking.
> 
> Fixes: 08d20ff62cde ('target: Acquire lun_entry_mutex during core_disable_device_list_for_node')
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> 
> diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
> index 2f4c8fa..20618df 100644
> --- a/drivers/target/target_core_device.c
> +++ b/drivers/target/target_core_device.c
> @@ -433,7 +433,7 @@ void core_clear_lun_from_tpg(struct se_lun *lun, struct se_portal_group *tpg)
>  
>  			core_disable_device_list_for_node(lun, deve, nacl, tpg);
>  		}
> -		mutex_lock(&nacl->lun_entry_mutex);
> +		mutex_unlock(&nacl->lun_entry_mutex);
>  	}
>  	mutex_unlock(&tpg->acl_node_mutex);
>  }

Applied to for-next, and will squash into the original soon.

Thanks Dan!

--nab

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/