linux-kernel - Re: [PATCH v7 1/5] random: Blocking API for accessing nonblocking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1985784.azciXBjbjY@tachyon.chronox.de>
Date:	Wed, 20 May 2015 21:38:38 +0200
From:	Stephan Mueller <smueller@...onox.de>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	pebolle@...cali.nl, andreas.steffen@...ongswan.org, tytso@....edu,
	sandyinchina@...il.com, linux-kernel@...r.kernel.org,
	linux-crypto@...r.kernel.org
Subject: Re: [PATCH v7 1/5] random: Blocking API for accessing nonblocking_pool

Am Mittwoch, 20. Mai 2015, 20:49:45 schrieb Stephan Mueller:

Hi Herbert,

> > This is just a convoluted way of doing an uninterruptible sleep.
> > Either make it uninterruptible or allow the function to return
> > an error.
> 
> Sorry, I overlooked the availability of wait_event. I was looking for it
> initially, but missed it. I will fix it right away.

After checking a bit more, I see that an uninterruptible sleep cannot be 
canceled with cancel_work_sync. Therefore, replacing it with wait_event does 
not work.

Thus, go get an uninterruptible sleep which yet can be canceled seems to 
require wait_event_interruptible together with the check for ERESTARTSYS.

Nonetheless, I move the loop out to the DRBG code as requested.

-- 
Ciao
Stephan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/