linux-kernel - Re: [PATCH v3] staging: rtl8712: Use ether_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <555CE72B.5060402@lwfinger.net>
Date:	Wed, 20 May 2015 14:57:31 -0500
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Jagan Teki <jteki@...nedev.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	devel@...verdev.osuosl.org,
	Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v3] staging: rtl8712: Use ether_addr_copy() instead of
 memcpy()

On 05/20/2015 02:46 PM, Jagan Teki wrote:
> On 21 May 2015 at 01:10, Larry Finger <Larry.Finger@...inger.net> wrote:
>> On 05/20/2015 01:41 PM, Jagan Teki wrote:
>>>
>>> On 18 May 2015 at 22:02, Jagan Teki <jteki@...nedev.com> wrote:
>>>>
>>>> Fixes Warning encounter this by applying checkpatch.pl against this file:
>>>> Prefer ether_addr_copy() over memcpy() if the Ethernet addresses
>>>> are __aligned(2)
>>>>
>>>> pahole output for respective structures:
>>>> - addr->sa_data
>>>> struct sockaddr {
>>>>           sa_family_t                sa_family;            /*     0     2
>>>> */
>>>>           char                       sa_data[14];          /*     2    14
>>>> */
>>>>
>>>>           /* size: 16, cachelines: 1, members: 2 */
>>>>           /* last cacheline: 16 bytes */
>>>> };
>>>>
>>>> - pnetdev->dev_addr
>>>> dev_addr is interface address infor from generic net_device structure
>>>> which is properly aligned and have some patches with this change as well.
>>>> "staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()"
>>>> (sha1: 36e4d8826b317080e283e4edd08bf8d5ac706f38)
>>>>
>>>> Signed-off-by: Jagan Teki <jteki@...nedev.com>
>>>> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>>>> Cc: Larry Finger <Larry.Finger@...inger.net>
>>>> Cc: Florian Schilhabel <florian.c.schilhabel@...glemail.com>
>>>> ---
>>>> Changes for v3:
>>>>           - Removed unaligned conversions
>>>> Changes for v2:
>>>>           - Describe a changelog, to prove address are aligned
>>>>
>>>>    drivers/staging/rtl8712/os_intfs.c | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/staging/rtl8712/os_intfs.c
>>>> b/drivers/staging/rtl8712/os_intfs.c
>>>> index 6e776e5..d5f4c4d 100644
>>>> --- a/drivers/staging/rtl8712/os_intfs.c
>>>> +++ b/drivers/staging/rtl8712/os_intfs.c
>>>> @@ -181,7 +181,7 @@ static int r871x_net_set_mac_address(struct
>>>> net_device *pnetdev, void *p)
>>>>           struct sockaddr *addr = p;
>>>>
>>>>           if (padapter->bup == false)
>>>> -               memcpy(pnetdev->dev_addr, addr->sa_data, ETH_ALEN);
>>>> +               ether_addr_copy(pnetdev->dev_addr, addr->sa_data);
>>>>           return 0;
>>>>    }
>>>>
>>>> --
>>>
>>>
>>> Ping!
>>
>>
>> Ah. Not only are you ignorant, but you are also rude! The patch was not
>> NACKed, thus it will be picked up in good time.
>
> What are these statements, sending a patch with valid proofs implies rudeness?
> Does this patch still have changes..?

No, that patch (V3) is OK. Sending a ping after 2 days is most certainly rude. 
That implies that no one has anything better to do than cater to your 
submissions. As Greg told you, wait for a while.

Larry


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/