linux-kernel - Re: [PATCH] regulator: core: fix constraints debug output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 20 May 2015 13:35:05 -0700
From:	Joe Perches <joe@...ches.com>
To:	Stefan Wahren <stefan.wahren@...e.com>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH] regulator: core: fix constraints debug output

On Wed, 2015-05-20 at 20:17 +0000, Stefan Wahren wrote:
> In the case uV_offset is greater than 0 the debug output before
> is accidentally overwritten. So take care of the output count.

If you are going to take care, please change all of these
sprintf calls to snprintf.

The buf array may not be big enough [80] to hold the longest
possible output string.

> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
[]
> @@ -801,7 +801,7 @@ static void print_constraints(struct regulator_dev *rdev)
>  	}
>  
>  	if (constraints->uV_offset)
> -		count += sprintf(buf, "%dmV offset ",
> +		count += sprintf(buf + count, "%dmV offset ",
>  				 constraints->uV_offset / 1000);
>  
>  	if (constraints->min_uA && constraints->max_uA) {



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/