lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 20 May 2015 13:41:03 +0900
From:	Chanwoo Choi <cw00.choi@...sung.com>
To:	linux-kernel@...r.kernel.org
Cc:	myungjoo.ham@...sung.com, cw00.choi@...sung.com,
	k.kozlowski@...sung.com, ckeepax@...nsource.wolfsonmicro.com,
	gg@...mlogic.co.uk, kishon@...com, jaewon02.kim@...sung.com,
	rogerq@...com, ramakrishna.pallala@...el.com, balbi@...com,
	aaro.koskinen@....fi
Subject: [PATCH v3 0/3] extcon: Use the unique id for each cable and update the
 extcon notifier

This patch-set update the extcon core to resolve the ambiguous identification
method for each external connectors. So, first patch define the unique id
for each external connector to identify them by using common unique id on
various extcon device driver as following:

enum extcon {
	EXTCON_NONE		= 0x0,

	/* USB external connector */
	EXTCON_USB		= 0x1,
	EXTCON_USB_HOST		= 0x2,

	/* Charger external connector */
	EXTCON_TA		= 0x10,
	EXTCON_FAST_CHARGER	= 0x11,
	EXTCON_SLOW_CHARGER	= 0x12,
	EXTCON_CHARGE_DOWNSTREAM= 0x13,

	.....
};

And the second patch simplify the prototype of extcon notifier's register
and unregister function with the unique id. All extcon driver have to use
the unique id (enum extcon definition) when registering the notifier and
getting/setting the state of cable state.
: int extcon_{register|unregister}_notifier(struct extcon_dev *edev,
				enum extcon id, struct notifier_block *nb)

In result, the extcon_{register|unregister}_interest() will be deprecated
by using the simply extcon_{register|unregister}_notifier().

Changes from v2:
- Update the description of following functions using the EXTCON_NONE to show
the end of array instead of NULL.
: extcon_dev_allocate() / devm_extcon_dev_allocate()

Changes from v1:
- Make separate patch about using the capital letter for the name of external connectors
- Make internal find_cable_index_by_{id|name}() to remove the duplicate code
- Code clean minor issue

Chanwoo Choi (3):
  extcon: Use the unique id for external connector instead of string
  extcon: Use capital letter for the name of external connectors
  extcon: Update the prototype of extcon_register_notifier() with enum extcon

 drivers/extcon/extcon-arizona.c        |  38 ++---
 drivers/extcon/extcon-axp288.c         |  24 ++-
 drivers/extcon/extcon-max14577.c       |  45 ++----
 drivers/extcon/extcon-max77693.c       |  95 +++++------
 drivers/extcon/extcon-max77843.c       |  56 +++----
 drivers/extcon/extcon-max8997.c        |  59 +++----
 drivers/extcon/extcon-palmas.c         |  22 +--
 drivers/extcon/extcon-rt8973a.c        |  40 ++---
 drivers/extcon/extcon-sm5502.c         |  32 ++--
 drivers/extcon/extcon-usb-gpio.c       |  32 +---
 drivers/extcon/extcon.c                | 277 ++++++++++++++++++---------------
 include/linux/extcon.h                 | 128 +++++++--------
 include/linux/extcon/extcon-adc-jack.h |   5 +-
 13 files changed, 387 insertions(+), 466 deletions(-)

-- 
1.8.5.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ