linux-kernel - Re: Audio crackles with 4.1-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hd21vu9k7.wl-tiwai@suse.de>
Date:	Wed, 20 May 2015 07:01:12 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Jonathan McDowell <noodles@...th.li>
Cc:	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: Audio crackles with 4.1-rc1

At Tue, 19 May 2015 22:53:10 +0100,
Jonathan McDowell wrote:
> 
> On Tue, May 19, 2015 at 07:09:12PM +0200, Takashi Iwai wrote:
> > At Tue, 19 May 2015 17:19:11 +0100,
> > Jonathan McDowell wrote:
> > > 
> > > On Tue, May 19, 2015 at 08:15:32AM +0200, Takashi Iwai wrote:
> > > > Does the patch below have any improvement?
> > > 
> > > I still get a clicking on the standby -> active transition with the
> > > patch provided on top of 4.1-rc4.
> > 
> > OK, just to be sure, could you check whether changing msleep(10) to
> > msleep(100) makes no difference?  Also put a line like
> > 	pr_info("XXX power up %x\n", nid);
> > after msleep() call to see which nodes are powered up dynamically.
> 
> Increasing the delay, if anything, makes the crackle when powering up
> seem a little longer. dmesg log looks like:
> 
> [ 4206.075557] XXX power up 2
> [ 4206.179671] XXX power up 14
> [ 4206.291758] XXX power up 3

OK, so everything looks correct, but the codec (or the machine) seems
leading to the noise when a branched path is activated while the pin
was already powered up.  Then let's disable the widget power-saving
for these codecs.

Could you confirm that the patch below works?


thanks,

Takashi

-- 8< --
From: Takashi Iwai <tiwai@...e.de>
Subject: [PATCH] ALSA: hda - Disable widget power-saving for ALC292 & co

We've got reports that ALC3226 (a Dell variant of ALC292) gives click
noises at transition from D3 to D0 when the widget power-saving is
enabled.  Further debugging session showed that avoiding it isn't
trivial, unfortunately, since paths are basically activated
dynamically while the pins have been already enabled.

This patch disables the widget power-saving for such codecs.

Reported-by: Jonathan McDowell <noodles@...th.li>
Signed-off-by: Takashi Iwai <tiwai@...e.de>
---
 sound/pci/hda/patch_realtek.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 2e246fe495f6..31f8f13be907 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -5623,7 +5623,8 @@ static int patch_alc269(struct hda_codec *codec)
 
 	spec = codec->spec;
 	spec->gen.shared_mic_vref_pin = 0x18;
-	codec->power_save_node = 1;
+	if (codec->core.vendor_id != 0x10ec0292)
+		codec->power_save_node = 1;
 
 	snd_hda_pick_fixup(codec, alc269_fixup_models,
 		       alc269_fixup_tbl, alc269_fixups);
-- 
2.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/