[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1432100032.3422.13.camel@mtksdaap41>
Date: Wed, 20 May 2015 13:33:52 +0800
From: Eddie Huang <eddie.huang@...iatek.com>
To: Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>
CC: Matthias Brugger <matthias.bgg@...il.com>,
Mark Rutland <mark.rutland@....com>,
Xudong Chen <xudong.chen@...iatek.com>,
srv_heupstream <srv_heupstream@...iatek.com>,
Pawel Moll <pawel.moll@....com>,
Wolfram Sang <wsa@...-dreams.de>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Liguo Zhang <liguo.zhang@...iatek.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
Rob Herring <robh+dt@...nel.org>,
<linux-mediatek@...ts.infradead.org>, <linux-i2c@...r.kernel.org>,
Sascha Hauer <kernel@...gutronix.de>,
Kumar Gala <galak@...eaurora.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v8 2/3] I2C: mediatek: Add driver for MediaTek I2C
controller
Hi Uwe,
On Tue, 2015-05-19 at 21:49 +0200, Uwe Kleine-König wrote:
> Hello Matthias,
>
> On Tue, May 19, 2015 at 04:48:23PM +0200, Matthias Brugger wrote:
> > 2015-05-18 20:43 GMT+02:00 Uwe Kleine-König <u.kleine-koenig@...gutronix.de>:
> > > On Tue, May 19, 2015 at 12:40:08AM +0800, Eddie Huang wrote:
> > >> [...]
> > >> drivers/i2c/busses/i2c-mt65xx.c | 675 ++++++++++++++++++++++++++++++++++++++++
> > >> [...]
> > >> +#define I2C_DRV_NAME "mt-i2c"
> > > i2c-mt65xx ?
> >
> > As this works for all SoCs so far, I would propose: i2c-mtk
> Hmm, currently we have:
>
> - #define I2C_DRV_NAME mt-i2c
Change to i2c-mt65xx.
> - dt-compatibles: "mediatek,mt6577-i2c" + "mediatek,mt6589-i2c"
We hope all mobile chip series use the same I2C driver.
I don't list all chips in driver to avoid too many dt-compatibles.
Only list chips that are different from others.
> - function prefix: mtk_i2c_
Maybe use i2c-mt65xx_ is better, but I tend to keep mtk_i2c_ after these
review rounds.
> - filename: i2c-mt65xx.c
> - Kconfig symbol: I2C_MT65XX
>
> Getting some harmonization here would definitly be nice.
>
Eddie Huang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists