linux-kernel - [PATCH v2 1/2] ras: hwpoison: fix build failure around trace_memory_failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150520060119.GB27005@hori1.linux.bs1.fc.nec.co.jp>
Date:	Wed, 20 May 2015 06:01:20 +0000
From:	Naoya Horiguchi <n-horiguchi@...jp.nec.com>
To:	Steven Rostedt <rostedt@...dmis.org>
CC:	Randy Dunlap <rdunlap@...radead.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Linux MM <linux-mm@...ck.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jim Davis <jim.epost@...il.com>,
	Chen Gong <gong.chen@...ux.intel.com>
Subject: [PATCH v2 1/2] ras: hwpoison: fix build failure around
 trace_memory_failure_event

Here's an updated patch.

# Randy, I dropped your Ack because there's a major change on this version.
# Would you mind looking at it, please?

---
next-20150515 fails to build on i386 with the following error:

  mm/built-in.o: In function `action_result':
  memory-failure.c:(.text+0x344a5): undefined reference to `__tracepoint_memory_failure_event'
  memory-failure.c:(.text+0x344d5): undefined reference to `__tracepoint_memory_failure_event'
  memory-failure.c:(.text+0x3450c): undefined reference to `__tracepoint_memory_failure_event'

The root cause of this error is the lack of dependency between CONFIG_RAS and
CONFIG_MEMORY_FAILURE.
"CONFIG_RAS=n and CONFIG_MEMORY_FAILURE=y" can happen on 32-bit systems with
CONFIG_SPARSEMEM=n (and all other dependencies of CONFIG_RAS from ACPI_EXTLOG/
PCIEAER/EDAC are false), but that's not supposed to happen.

Reported-by: Randy Dunlap <rdunlap@...radead.org>
Reported-by: Jim Davis <jim.epost@...il.com>
Signed-off-by: Naoya Horiguchi <n-horiguchi@...jp.nec.com>
---
 mm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mm/Kconfig b/mm/Kconfig
index 52ffb863383c..e79de2bd12cd 100644
--- a/mm/Kconfig
+++ b/mm/Kconfig
@@ -368,6 +368,7 @@ config MEMORY_FAILURE
 	depends on ARCH_SUPPORTS_MEMORY_FAILURE
 	bool "Enable recovery from hardware memory errors"
 	select MEMORY_ISOLATION
+	select RAS
 	help
 	  Enables code to recover from some memory failures on systems
 	  with MCA recovery. This allows a system to continue running
-- 
2.1.0
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/