linux-kernel - Re: mod_devicetable: Make dmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <555C36D1.4060003@suse.cz>
Date:	Wed, 20 May 2015 15:25:05 +0800
From:	Michal Marek <mmarek@...e.cz>
To:	Rusty Russell <rusty@...tcorp.com.au>,
	Joe Perches <joe@...ches.com>,
	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
CC:	David Woodhouse <dwmw2@...radead.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Quentin Casasnovas <quentin.casasnovas@...cle.com>,
	Andreas Schwab <schwab@...ux-m68k.org>
Subject: Re: mod_devicetable: Make dmi_strmatch.substr const char *

Dne 20.5.2015 v 13:19 Rusty Russell napsal(a):
> Joe Perches <joe@...ches.com> writes:
>> On Tue, 2015-05-19 at 16:56 +0100, One Thousand Gnomes wrote:
>>> On Tue, 19 May 2015 07:46:58 +0100 David Woodhouse <dwmw2@...radead.org> wrote:
>>>> On Mon, 2015-05-18 at 17:07 -0700, Joe Perches wrote:
>>>>> changed dmi_strmatch.substr from char * to char[79];
>>>>>
>>>>> Changing it back to const char * would shrink an x86-64
>>>>> defconfig more than 100KB.

As David already pointed out, this breaks modpost. Also, what makes the
dmi tables special? We use character arrays in other tables as well, to
make them self-contained for modpost.


> But it seems the file2alias code was rewritten in 2013 by Andreas Schwab
> <schwab@...ux-m68k.org>, and SOB Michal Marek <mmarek@...e.cz>, without
> going through me.  Annoying, since they had to hack it because people
> screwed up mod_devicetable.h with arch-dependent layouts :(

Oh, sorry about it.


> I guess that means Michal is the maintainer now, so I've CC'd him.

OK, fine, I can carry modpost patches in kbuid.git. I think I have
merged a few more besides the file2alias rework.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/