linux-kernel - Re: [PATCH 3/9] KVM: const-ify uses of struct kvm_userspace_memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <555C4301.3070806@lab.ntt.co.jp>
Date:	Wed, 20 May 2015 17:17:05 +0900
From:	Takuya Yoshikawa <yoshikawa_takuya_b1@....ntt.co.jp>
To:	Paolo Bonzini <pbonzini@...hat.com>, linux-kernel@...r.kernel.org,
	kvm@...r.kernel.org
CC:	Xiao Guangrong <guangrong.xiao@...ux.intel.com>, rkrcmar@...hat.com
Subject: Re: [PATCH 3/9] KVM: const-ify uses of struct kvm_userspace_memory_region

On 2015/05/20 2:25, Paolo Bonzini wrote:
> Architecture-specific helpers are not supposed to muck with
> struct kvm_userspace_memory_region contents.  Add const to
> enforce this.

Nice, this is what I wanted to do, but could not do, when I
cleaned up these functions a few years ago.

> 
> In order to eliminate the only write in __kvm_set_memory_region,
> the cleaning of deleted slots is pulled up from update_memslots
> to __kvm_set_memory_region.

-	if (!npages)
-		mem->flags &= ~KVM_MEM_LOG_DIRTY_PAGES;

Especially, removing this hard-to-understand lines is really
nice.

> 
> Signed-off-by: Paolo Bonzini <pbonzini@...hat.com>

Reviewed-by: Takuya Yoshikawa <yoshikawa_takuya_b1@....ntt.co.jp>


	Takuya


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/