linux-kernel - Re: [PATCH v2 2/3] fbcon: use the cursor blink interval provided by vt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1505200022510.1617@local>
Date:	Wed, 20 May 2015 00:36:24 +0000 (UTC)
From:	Scot Doyle <lkml14@...tdoyle.com>
To:	Thierry Reding <thierry.reding@...il.com>
cc:	Kevin Hilman <khilman@...nel.org>,
	Scot Doyle <lkml14@...tdoyle.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Tomi Valkeinen <tomi.valkeinen@...com>,
	Michael Kerrisk <mtk.manpages@...il.com>,
	Jiri Slaby <jslaby@...e.cz>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Pavel Machek <pavel@....cz>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	lkml <linux-kernel@...r.kernel.org>, linux-fbdev@...r.kernel.org,
	linux-man@...r.kernel.org, linux-api@...r.kernel.org,
	Tyler Baker <tyler.baker@...aro.org>,
	Olof Johansson <olof@...om.net>,
	Daniel Stone <daniel@...ishbar.org>,
	Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v2 2/3] fbcon: use the cursor blink interval provided by
 vt

On Tue, 19 May 2015, Thierry Reding wrote:
> On Tue, May 19, 2015 at 02:45:19PM -0700, Kevin Hilman wrote:
> > On Tue, May 19, 2015 at 2:40 PM, Thierry Reding
> > <thierry.reding@...il.com> wrote:

...

> > >
> > > FWIW, if I apply the below on top of next-20150519 things seem to be
> > > back to normal as well:
> > >
> > > diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
> > > index 05b1d1a71ef9..658c34bb9076 100644
> > > --- a/drivers/video/console/fbcon.c
> > > +++ b/drivers/video/console/fbcon.c
> > > @@ -1310,8 +1310,9 @@ static void fbcon_cursor(struct vc_data *vc, int mode)
> > >                 return;
> > >
> > >         ops->cur_blink_jiffies = msecs_to_jiffies(vc->vc_cur_blink_ms);
> > > -       fbcon_del_cursor_timer(info);
> > > -       if (!(vc->vc_cursor_type & 0x10))
> > > +       if (vc->vc_cursor_type & 0x10)
> > > +               fbcon_del_cursor_timer(info);
> > > +       else
> > >                 fbcon_add_cursor_timer(info);
> > >
> > >         ops->cursor_flash = (mode == CM_ERASE) ? 0 : 1;
> > 
> > Applying this on next-20150519 makes my exynos board happily boot again as well.
> > 
> > Tested-by: Kevin Hilman <khilman@...aro.org>
> 
> Excellent. Greg, Scot, any opinions on whether or not this is the right
> thing to do? It restores a bit that looks suspiciously like it snuck in
> in the original (at least it isn't documented in the commit message).
> 
> Greg, feel free to squash this in if everybody agrees this is good to
> go. If you prefer a patch on top let me know and I'll come up with a
> proper commit message.
> 
> Thierry

Hi all, sorry for the trouble.

The timer delete was to prevent blink stutter when updating the interval. 
Since the stutter isn't so noticable when changing from the default 200ms, 
and since most people seem to prefer leaving the fbcon code alone if 
possible, I agree with Thierry's approach.

Tested-by: Scot Doyle <lkml14@...tdoyle.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/