linux-kernel - Re: [PATCH v3 1/2] Staging: comedi: fix line longer than 80 chars in cb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 20 May 2015 13:52:23 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Amaury Denoyelle <amaury.denoyelle@...il.com>
Cc:	Ian Abbott <abbotti@....co.uk>, devel@...verdev.osuosl.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	H Hartley Sweeten <hsweeten@...ionengravers.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] Staging: comedi: fix line longer than 80 chars in
 cb_pcidas64.c

On Wed, May 20, 2015 at 09:24:18AM +0200, Amaury Denoyelle wrote:
> Sudip Mukherjee <sudipm.mukherjee@...il.com> wrote:
> 
> > On Tue, May 19, 2015 at 07:57:49PM +0200, Amaury Denoyelle wrote:
> > <snip>
> > > @@ -1381,7 +1382,9 @@ static int set_ai_fifo_segment_length(struct comedi_device *dev,
> > >  	return devpriv->ai_fifo_segment_length;
> > >  }
> > >  
> > > -/* adjusts the size of hardware fifo (which determines block size for dma xfers) */
> > > +/*
> > > + * adjusts the size of hardware fifo (which determines block size for dma xfers)
> > > + */
> > I did not understand this one. You are not breaking the comment into
> > two lines, then why multiline style?
> > 
> > >  	const struct pcidas64_board *thisboard = dev->board_ptr;
> > > @@ -1588,7 +1591,9 @@ static inline void warn_external_queue(struct comedi_device *dev)
> > >  		"Use internal AI channel queue (channels must be consecutive and use same range/aref)\n");
> > >  }
> > >  
> > > -/* Their i2c requires a huge delay on setting clock or data high for some reason */
> > > +/*
> > > + * their i2c requires a huge delay on setting clock or data high for some reason
> > > + */
> > same here.
> > 
> 
> The single-line version of these comments are over 80 characters (just
> because of the "*/" characters), so I had to split them over several
> lines.
yes, i noticed. its almost 84 char. but after applying your patch also
it comes to 81.

what about:

/*
 * Their i2c requires a huge delay on setting clock or data high
 * for some reason
 */ 

regards
sudip

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/