linux-kernel - Re: [PATCH v5 WIP 5/5] paride: use new parport device model

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 20 May 2015 14:03:13 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Jean Delvare <jdelvare@...e.de>
Cc:	Greg KH <gregkh@...uxfoundation.org>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 WIP 5/5] paride: use new parport device model

On Wed, May 20, 2015 at 10:07:48AM +0200, Jean Delvare wrote:
> Hi Sudip,
> 
> On Wed,  6 May 2015 15:46:17 +0530, Sudip Mukherjee wrote:
> > modify paride driver to use the new parallel port device model.
> 
> Leading capital please ;-)
yes, its the linux habit of writing in small letters. :)
> 
> > 
> > Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
> > ---
> > 
> > +	}
> > +	par_cb->flags = 0;
> > +	par_cb->wakeup = pi_wake_up;
> > +	par_cb->private = (void *)pi;
> > +	pi->pardev = parport_register_dev_model(port, pi->device, par_cb,
> > +						unit);
> 
> If pi->device already includes the device number, and you are passing
> it again as unit, won't you end up with odd names like pcd0.0, pcd1.1,
> pcd2.2 etc?
yes, it is. This is the only driver using parport where in the probe
i had to use strncmp again.

> 
> >  	parport_put_port(port);
> > +	kfree(par_cb);
> 
> If you don't need par_cb anywhere else then you shouldn't be allocating
> it dynamically. It's small enough to fit on the stack really.
like you suggested, I will make it local in all the drivers.

regards
sudip.
> 
> -- 
> Jean Delvare
> SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/