linux-kernel - Re: perf: odd event scheduling issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150520092842.GF18673@twins.programming.kicks-ass.net>
Date:	Wed, 20 May 2015 11:28:42 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Vince Weaver <vincent.weaver@...ne.edu>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Stephane Eranian <eranian@...gle.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Jiri Olsa <jolsa@...hat.com>, Ingo Molnar <mingo@...hat.com>,
	Paul Mackerras <paulus@...ba.org>
Subject: Re: perf: odd event scheduling issue

On Wed, May 20, 2015 at 09:00:57AM +0200, Peter Zijlstra wrote:
> On Tue, May 19, 2015 at 11:07:09PM -0400, Vince Weaver wrote:
> > Hello
> > 
> > so I'm running 4.1-rc4 on my Haswell machine and a lot of my perf_event 
> > testsuite is failing.  There seems to be weird event scheduling issues.
> > 
> > I can reproduce it with plain perf; simple event groups that should work 
> > fine can't be scheduled.
> > 
> > vince@...well:~$ perf stat -e \{cycles,instructions\} sleep 1
> > 
> 
> Hmm indeed, my ivb-ep does the same thing. Lemme go poke at that.

I've gotta go pick the kid up from school, but the bisect just finished
and threw up the below commit.

I'll go stare at it in an hour or so.

---

c02cdbf60b51b8d98a49185535f5d527a2965142 is the first bad commit
commit c02cdbf60b51b8d98a49185535f5d527a2965142
Author: Stephane Eranian <eranian@...gle.com>
Date:   Mon Nov 17 20:07:02 2014 +0100

    perf/x86/intel: Limit to half counters when the HT workaround is enabled, to avoid exclusive mode starvation
    
    This patch limits the number of counters available to each CPU when
    the HT bug workaround is enabled.
    
    This is necessary to avoid situation of counter starvation. Such can
    arise from configuration where one HT thread, HT0, is using all 4 counters
    with corrupting events which require exclusion the the sibling HT, HT1.
    
    In such case, HT1 would not be able to schedule any event until HT0
    is done. To mitigate this problem, this patch artificially limits
    the number of counters to 2.
    
    That way, we can gurantee that at least 2 counters are not in exclusive
    mode and therefore allow the sibling thread to schedule events of the
    same type (system vs. per-thread). The 2 counters are not determined
    in advance. We simply set the limit to two events per HT.
    
    This helps mitigate starvation in case of events with specific counter
    constraints such a PREC_DIST.
    
    Note that this does not elimintate the starvation is all cases. But
    it is better than not having it.
    
    (Solution suggested by Peter Zjilstra.)
    
    Signed-off-by: Stephane Eranian <eranian@...gle.com>
    Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
    Cc: bp@...en8.de
    Cc: jolsa@...hat.com
    Cc: kan.liang@...el.com
    Cc: maria.n.dimakopoulou@...il.com
    Link: http://lkml.kernel.org/r/1416251225-17721-11-git-send-email-eranian@google.com
    Signed-off-by: Ingo Molnar <mingo@...nel.org>

:040000 040000 d78b3927f7fb17a34079012f7184aeef6120e411 84a0237880834d5b58b357fb58ff816124718545 M      arch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/