linux-kernel - Re: [PATCH 4/5] kconfig: Introduce "showif" to factor out conditions on visibility

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1432116013.21715.82.camel@x220>
Date:	Wed, 20 May 2015 12:00:13 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Josh Triplett <josh@...htriplett.org>
Cc:	Ingo Molnar <mingo@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Michal Hocko <mhocko@...e.cz>,
	Vladimir Davydov <vdavydov@...allels.com>,
	Johannes Weiner <hannes@...xchg.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Andy Lutomirski <luto@...capital.net>,
	Bertrand Jacquin <beber@...eeweb.net>,
	"Luis R. Rodriguez" <mcgrof@...e.com>,
	Iulia Manda <iulia.manda21@...il.com>,
	Pranith Kumar <bobby.prani@...il.com>,
	Clark Williams <clark.williams@...il.com>,
	Mel Gorman <mgorman@...e.de>,
	Randy Dunlap <rdunlap@...radead.org>,
	Michal Marek <mmarek@...e.cz>, linux-kbuild@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] kconfig: Introduce "showif" to factor out
 conditions on visibility

Hi Josh,

On Thu, 2015-05-14 at 08:36 -0700, Josh Triplett wrote:
> kconfig implicitly creates a submenu whenever a series of symbols all
> have dependencies or prompt-visibility expressions that all depend on a
> preceeding symbol.  For instance, the series of symbols following
> "menuconfig EXPERT" that all have "if EXPERT" on their prompt will all
> appear as a submenu of EXPERT.
> 
> However, this implicit submenuing will break if any intervening symbol
> loses its "if EXPERT"; doing so causes the subsequent symbols to appear
> in the parent menu ("General setup").  This has happened many times, and
> it's easy to miss that the entire block should have that same
> expression.
> 
> For submenus created from "depends" dependencies, these can be converted
> to a single wrapping "if expr ... endif" block around all the submenu
> items.  However, there's no equivalent for invisible items, for which
> the prompt is hidden but the symbol may potentially be enabled.  For
> instance, many items in the EXPERT menu are hidden if EXPERT is
> disabled, but they have "default y" or are determined by some other
> expression.

No one has reacted so far. So my plan to have the other people on
linux-kbuild do the work here is not going as I'd hoped. Bother...

I seem to remember that you had a list of three dozen menuconfig
instances that ran into the same issue as EXPERT's menuconfig. Do you
still have that list at hand?

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/