linux-kernel - Re: [PATCH v5 00/12] ARM: berlin: add nand support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150520140832.GO22054@kwain>
Date:	Wed, 20 May 2015 16:08:32 +0200
From:	Antoine Tenart <antoine.tenart@...e-electrons.com>
To:	Ezequiel Garcia <ezequiel@...guardiasur.com.ar>
Cc:	Antoine Tenart <antoine.tenart@...e-electrons.com>,
	sebastian.hesselbarth@...il.com, dwmw2@...radead.org,
	computersforpeace@...il.com, boris.brezillon@...e-electrons.com,
	zmxu@...vell.com, jszhang@...vell.com,
	linux-arm-kernel@...ts.infradead.org,
	linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 00/12] ARM: berlin: add nand support

On Sat, May 16, 2015 at 06:37:51PM -0300, Ezequiel Garcia wrote:
> Hi Antoine,
> 
> This is a long patchset, which involves some very invasive changes
> to the driver. So, I think it'll be better to split it in different
> patchsets.
> 
> On 05/11/2015 11:58 AM, Antoine Tenart wrote:
> [..]
> > 
> > Antoine Tenart (12):
> 
> These two clock patches are related to Berlin support only.
> 
> >   mtd: pxa3xx_nand: add a non mandatory ECC clock
> >   Documentation: bindings: document the clocks for pxa3xx-nand
> 
> The next four patches rework the timing setup and remove the legacy
> device detection. I think we should try to get them merged in first place.
> 
> >   mtd: pxa3xx_nand: add a default chunk size
> >   mtd: pxa3xx_nand: add helpers to setup the timings
> >   mtd: pxa3xx_nand: rework flash detection and timing setup
> >   mtd: pxa3xx_nand: clean up the pxa3xx timings
> 
> Next one just adds support for a new device. It has little to do with
> the series. I already replied about using JEDEC ID; once we solve that,
> I suggest that you submit this patch alone.
> 
> >   mtd: nand: add Samsung K9GBG08U0A-M to nand_ids table
> 
> And finally, once we solve the timing rework, we can go through Berlin
> support.
> 
> >   mtd: pxa3xx_nand: add support for the Marvell Berlin nand controller
> >   Documentation: bindings: add the Berlin nand controller compatible
> >   mtd: nand: let Marvell Berlin SoCs select the pxa3xx driver
> >   ARM: berlin: add BG2Q node for the nand
> >   ARM: berlin: enable flash on the BG2Q DMP
> > 
> 
> What do you think?

So we'd have 3 series:
- Timing rework.
- Berlin stuff.
- Samsung K9GBG08U0A-M support.

I'm OK with splitting the series to ease the review process :)

Antoine

-- 
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/