linux-kernel - Re: [PATCH RESEND] hid:Change vendor id for USB_DEVICE_ID_MS_TYPE_COVER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 20 May 2015 16:27:56 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	nick <xerofoify@...il.com>
cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND] hid:Change vendor id for USB_DEVICE_ID_MS_TYPE_COVER_3
 to correct id in hid-ids.h

On Wed, 20 May 2015, nick wrote:

> >>> This fixes the bug,https://bugzilla.kernel.org/show_bug.cgi?id=97951 
> >>> related to incorrecting using 0x07dc for the vendor id for 
> >>> USB_DEVICE_ID_MS_TYPE_COVER_3 devices and instead changing in 
> >>> to the correct vendor id of 0x07de.
> >>>
> >>> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> >>> ---
> >>>  drivers/hid/hid-ids.h | 2 +-
> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> >>> index 41f167e..2e51947 100644
> >>> --- a/drivers/hid/hid-ids.h
> >>> +++ b/drivers/hid/hid-ids.h
> >>> @@ -670,7 +670,7 @@
> >>>  #define USB_DEVICE_ID_MS_SURFACE_PRO_2   0x0799
> >>>  #define USB_DEVICE_ID_MS_TOUCH_COVER_2   0x07a7
> >>>  #define USB_DEVICE_ID_MS_TYPE_COVER_2    0x07a9
> >>> -#define USB_DEVICE_ID_MS_TYPE_COVER_3    0x07dc
> >>> +#define USB_DEVICE_ID_MS_TYPE_COVER_3    0x07de
> >>>  #define USB_DEVICE_ID_MS_TYPE_COVER_3_JP 0x07dd
> >>>  
> >>>  #define USB_VENDOR_ID_MOJO		0x8282
> >>
> >> Why are you resending this without reacting to my original response to 
> >> your mail?
> >>
> > This has been discussed as Alan stated the device he has comes with the American and not the Japanese vendor ID . If you still don't believe me I will quote his exact words. 
> > Nick 
> >> 	http://lkml.iu.edu/hypermail/linux/kernel/1505.1/01419.html
> > 
> Jiri, I have not heard a respond about this patch being accepted. If you 
> can get another to replying to me this week about it that would be 
> great.

I still haven't received any pointer or reason why we don't want both 
(i.e. how come that 0x07dc was initially submitted and all of a sudden 
it's not needed).

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/