linux-kernel - Re: [PATCH] tty: serial/8250: remove console dependency for mediatek

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1432085679.18194.1.camel@mtksdaap41>
Date:	Wed, 20 May 2015 09:34:39 +0800
From:	Eddie Huang <eddie.huang@...iatek.com>
To:	Arnd Bergmann <arnd@...db.de>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Matthias Brugger <matthias.bgg@...il.com>,
	<linux-serial@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-mediatek@...ts.infradead.org>, Jiri Slaby <jslaby@...e.cz>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tty: serial/8250: remove console dependency for mediatek

Hi Arnd,

On Tue, 2015-05-19 at 22:11 +0200, Arnd Bergmann wrote:
> If the mediatek serial port driver is built-in, but serial
> console is disabled in Kconfig (e.g. when the serial driver
> itself is a loadable module), we get this build error:
> 
> drivers/built-in.o: In function `early_mtk8250_setup':
> undefined reference to `early_serial8250_setup'
> 
> To avoid that problem, this patch encloses the early_mtk8250_setup
> function in #ifdef CONFIG_SERIAL_8250_CONSOLE, the same symbol
> that guards the early_serial8250_setup function.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> 
> diff --git a/drivers/tty/serial/8250/8250_mtk.c b/drivers/tty/serial/8250/8250_mtk.c
> index 4488c2bdb7ba..78883ca64ddd 100644
> --- a/drivers/tty/serial/8250/8250_mtk.c
> +++ b/drivers/tty/serial/8250/8250_mtk.c
> @@ -305,6 +305,7 @@ static struct platform_driver mtk8250_platform_driver = {
>  };
>  module_platform_driver(mtk8250_platform_driver);
>  
> +#ifdef CONFIG_SERIAL_8250_CONSOLE
>  static int __init early_mtk8250_setup(struct earlycon_device *device,
>  					const char *options)
>  {
> @@ -317,6 +318,7 @@ static int __init early_mtk8250_setup(struct earlycon_device *device,
>  }
>  
>  OF_EARLYCON_DECLARE(mtk8250, "mediatek,mt6577-uart", early_mtk8250_setup);
> +#endif
>  
>  MODULE_AUTHOR("Matthias Brugger");
>  MODULE_LICENSE("GPL");
> 

Acked-by: Eddie Huang <eddie.huang@...iatek.com>

Thanks your correction.

Eddie




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/