linux-kernel - Re: [PATCH 4/6] i2c-parport: use new parport device model

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150520154907.GB2001@katana>
Date:	Wed, 20 May 2015 17:49:07 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Tim Waugh <tim@...erelk.net>, Jean Delvare <jdelvare@...e.de>,
	Willy Tarreau <willy@...a-x.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Alan Cox <gnomes@...rguk.ukuu.org.uk>,
	linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
	devel@...verdev.osuosl.org
Subject: Re: [PATCH 4/6] i2c-parport: use new parport device model

On Wed, May 20, 2015 at 08:57:00PM +0530, Sudip Mukherjee wrote:
> Modify i2c-parport driver to use the new parallel port device model.
> 
> Tested-by: Jean Delvare <jdelvare@...e.de>
> Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
> ---

In general:

Acked-by: Wolfram Sang <wsa@...-dreams.de>

>  static struct parport_driver i2c_parport_driver = {
> -	.name	= "i2c-parport",
> -	.attach	= i2c_parport_attach,
> -	.detach	= i2c_parport_detach,
> +	.name		= "i2c-parport",
> +	.match_port	= i2c_parport_attach,
> +	.detach		= i2c_parport_detach,
> +	.devmodel	= true,

Minor nit: I prefer to not use tabs but a single space after the struct
member names. Less hazzle in the future and still readable IMO.


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)