lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 20 May 2015 17:51:56 +0200 From: Oleg Nesterov <oleg@...hat.com> To: Pratyush Anand <panand@...hat.com> Cc: Ananth N Mavinakayanahalli <ananth@...ibm.com>, Anton Arapov <arapov@...il.com>, David Long <dave.long@...aro.org>, Denys Vlasenko <dvlasenk@...hat.com>, "Frank Ch. Eigler" <fche@...hat.com>, Ingo Molnar <mingo@...nel.org>, Jan Willeke <willeke@...ibm.com>, Jim Keniston <jkenisto@...ibm.com>, Mark Wielaard <mjw@...hat.com>, Srikar Dronamraju <srikar@...ux.vnet.ibm.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 07/10] uprobes/x86: Introduce arch_uretprobe_is_alive() Hi Pratyush, sorry for delay, vacation. On 05/18, Pratyush Anand wrote: > Hi Oleg, > > On Monday 04 May 2015 06:19 PM, Oleg Nesterov wrote: >> +bool __weak arch_uretprobe_is_alive(struct arch_uretprobe *auret, struct pt_regs *regs) >> +{ >> + return true; >> +} > > IIUC, then this function should return false when both auret and regs > are corresponding to same retprobe, else we need to return true, right? Not sure I understand what you mean... This function should return false when we know that this return_instance was invalidated by longjmp(). > If that is the case, then should n't following work for all the cases: > > return sp != auret->sp; No, this can't work. On x86 "sp == auret->sp" only right after the "call" insn, the stack can grow after that but this does not mean that this instance is no longer valid. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists