linux-kernel - Re: [PATCH v5 20/21] clk: tegra210: add support for Tegra210 clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <555CC1A2.9070605@nvidia.com>
Date:	Wed, 20 May 2015 13:17:22 -0400
From:	Rhyland Klein <rklein@...dia.com>
To:	Benson Leung <bleung@...omium.org>
CC:	Peter De Schrijver <pdeschrijver@...dia.com>,
	Mike Turquette <mturquette@...aro.org>,
	Stephen Warren <swarren@...dotorg.org>,
	Stephen Boyd <sboyd@...eaurora.org>,
	Thierry Reding <thierry.reding@...il.com>,
	Alexandre Courbot <gnurou@...il.com>,
	Bill Huang <bilhuang@...dia.com>,
	Paul Walmsley <pwalmsley@...dia.com>,
	Jim Lin <jilin@...dia.com>, <linux-clk@...r.kernel.org>,
	<linux-tegra@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 20/21] clk: tegra210: add support for Tegra210 clocks

On 5/14/2015 4:23 PM, Benson Leung wrote:
> On Tue, May 12, 2015 at 10:24 AM, Rhyland Klein <rklein@...dia.com> wrote:
>> +static int _p_div_to_hw(struct clk_hw *hw, u8 p_div)
>> +{
>> +       struct tegra_clk_pll *pll = to_clk_pll(hw);
>> +       struct pdiv_map *p_tohw = pll->params->pdiv_tohw;
>> +
>> +       if (p_tohw) {
>> +               while (p_tohw->pdiv) {
>> +                       if (p_div <= p_tohw->pdiv)
>> +                               return p_tohw->hw_val;
>> +                       p_tohw++;
>> +               }
>> +               return -EINVAL;
>> +       }
>> +       return -EINVAL;
>> +}
> 
> This is the same function as the one that lives in clk-pll.c. Can you
> make these common?
> 
Sure, I'll add that for v6.

-rhyland


-- 
nvpublic
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/